You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Michael Dürig (JIRA)" <ji...@apache.org> on 2015/04/22 15:54:58 UTC

[jira] [Comment Edited] (OAK-2801) Clear excess references before cleanup

    [ https://issues.apache.org/jira/browse/OAK-2801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14507109#comment-14507109 ] 

Michael Dürig edited comment on OAK-2801 at 4/22/15 1:54 PM:
-------------------------------------------------------------

Graphs showing the file store size and the depth and weight of the compaction map with and without the patch. Top graph shows file store size in bytes, middle graph shows compaction map weight in bytes and bottom graph shows compaction map depths. 

The data has been collected through the {{SegmentCompactionITMBean}} while running {{SegmentCompactionIT}} with 10 readers, 10 references and 20 writers. 

Without  the patch there is no cleanup taking place. This is caused by too many concurrent writers keeping too many references around. With the patch cleanup takes place regularly. 


was (Author: mduerig):
Graphs showing the file store size and the depth and width of the compaction map with and without the patch. 

The data has been collected through the {{SegmentCompactionITMBean}} while running {{SegmentCompactionIT}} with 10 readers, 10 references and 20 writers. 

Without  the patch there is no cleanup taking place. This is caused by too many concurrent writers keeping too many references around. With the patch cleanup takes place regularly. 

> Clear excess references before cleanup
> --------------------------------------
>
>                 Key: OAK-2801
>                 URL: https://issues.apache.org/jira/browse/OAK-2801
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: segmentmk
>            Reporter: Michael Dürig
>            Assignee: Michael Dürig
>              Labels: compaction, gc
>             Fix For: 1.3.0
>
>         Attachments: OAK-2801.patch, with-OAK-2801.png, without-OAK-2801.png
>
>
> {{FileStore#cleanup}} would be more efficient when getting rid of as much references as possibly beforehand. Excess references are contributed by the current {{TarWriter}} instance and segment cache in {{SegmentTracker}}. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)