You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2017/03/03 15:43:10 UTC

Review Request 57293: All HBase Masters listed as in standby if Hbase ssl is enabled.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57293/
-----------------------------------------------------------

Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.


Bugs: AMBARI-20305
    https://issues.apache.org/jira/browse/AMBARI-20305


Repository: ambari


Description
-------

Ambari fails to get jmx metrics from Hbase if it's running with https protocol
03 Mar 2017 15:24:00,903 ERROR [ambari-metrics-retrieval-service-thread-17] MetricsRetrievalService:481 - Unable to retrieve metrics from http://host1:30010/jmx. Subsequent failures will be suppressed from the log for 20 minutes.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java 6967fee 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java 270d50a 


Diff: https://reviews.apache.org/r/57293/diff/1/


Testing
-------

Unit tests passed


Thanks,

Dmytro Sen


Re: Review Request 57293: All HBase Masters listed as in standby if Hbase ssl is enabled.

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57293/#review167862
-----------------------------------------------------------


Ship it!




Ship It!

- Vitalyi Brodetskyi


On \u0411\u0435\u0440\u0435\u0437\u0435\u043d\u044c 3, 2017, 3:43 \u043f\u0456\u0441\u043b\u044f \u043f\u043e\u043b\u0443\u0434\u043d\u044f, Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57293/
> -----------------------------------------------------------
> 
> (Updated \u0411\u0435\u0440\u0435\u0437\u0435\u043d\u044c 3, 2017, 3:43 \u043f\u0456\u0441\u043b\u044f \u043f\u043e\u043b\u0443\u0434\u043d\u044f)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20305
>     https://issues.apache.org/jira/browse/AMBARI-20305
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ambari fails to get jmx metrics from Hbase if it's running with https protocol
> 03 Mar 2017 15:24:00,903 ERROR [ambari-metrics-retrieval-service-thread-17] MetricsRetrievalService:481 - Unable to retrieve metrics from http://host1:30010/jmx. Subsequent failures will be suppressed from the log for 20 minutes.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java 6967fee 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java 270d50a 
> 
> 
> Diff: https://reviews.apache.org/r/57293/diff/1/
> 
> 
> Testing
> -------
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Re: Review Request 57293: All HBase Masters listed as in standby if Hbase ssl is enabled.

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57293/#review167942
-----------------------------------------------------------


Ship it!




Ship It!

- Alejandro Fernandez


On March 3, 2017, 3:43 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57293/
> -----------------------------------------------------------
> 
> (Updated March 3, 2017, 3:43 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20305
>     https://issues.apache.org/jira/browse/AMBARI-20305
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ambari fails to get jmx metrics from Hbase if it's running with https protocol
> 03 Mar 2017 15:24:00,903 ERROR [ambari-metrics-retrieval-service-thread-17] MetricsRetrievalService:481 - Unable to retrieve metrics from http://host1:30010/jmx. Subsequent failures will be suppressed from the log for 20 minutes.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java 6967fee 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java 270d50a 
> 
> 
> Diff: https://reviews.apache.org/r/57293/diff/1/
> 
> 
> Testing
> -------
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Re: Review Request 57293: All HBase Masters listed as in standby if Hbase ssl is enabled.

Posted by Sumit Mohanty <sm...@hortonworks.com>.

> On March 3, 2017, 9:56 p.m., Sumit Mohanty wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
> > Line 178 (original), 178 (patched)
> > <https://reviews.apache.org/r/57293/diff/1/?file=1655490#file1655490line178>
> >
> >     Should this be an OR - if hbase.ssl.enabled is true or hbase.http.policy is true?

I see that Josh from HBase has reviewed it. +1


- Sumit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57293/#review167875
-----------------------------------------------------------


On March 3, 2017, 3:43 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57293/
> -----------------------------------------------------------
> 
> (Updated March 3, 2017, 3:43 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20305
>     https://issues.apache.org/jira/browse/AMBARI-20305
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ambari fails to get jmx metrics from Hbase if it's running with https protocol
> 03 Mar 2017 15:24:00,903 ERROR [ambari-metrics-retrieval-service-thread-17] MetricsRetrievalService:481 - Unable to retrieve metrics from http://host1:30010/jmx. Subsequent failures will be suppressed from the log for 20 minutes.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java 6967fee 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java 270d50a 
> 
> 
> Diff: https://reviews.apache.org/r/57293/diff/1/
> 
> 
> Testing
> -------
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Re: Review Request 57293: All HBase Masters listed as in standby if Hbase ssl is enabled.

Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57293/#review167875
-----------------------------------------------------------




ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
Line 178 (original), 178 (patched)
<https://reviews.apache.org/r/57293/#comment239839>

    Should this be an OR - if hbase.ssl.enabled is true or hbase.http.policy is true?


- Sumit Mohanty


On March 3, 2017, 3:43 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57293/
> -----------------------------------------------------------
> 
> (Updated March 3, 2017, 3:43 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20305
>     https://issues.apache.org/jira/browse/AMBARI-20305
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ambari fails to get jmx metrics from Hbase if it's running with https protocol
> 03 Mar 2017 15:24:00,903 ERROR [ambari-metrics-retrieval-service-thread-17] MetricsRetrievalService:481 - Unable to retrieve metrics from http://host1:30010/jmx. Subsequent failures will be suppressed from the log for 20 minutes.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java 6967fee 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java 270d50a 
> 
> 
> Diff: https://reviews.apache.org/r/57293/diff/1/
> 
> 
> Testing
> -------
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>