You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/10/08 17:37:27 UTC
[jira] [Commented] (THRIFT-3253) Using latest version of D gives deprecation notices

    [ https://issues.apache.org/jira/browse/THRIFT-3253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14948860#comment-14948860 ] 

ASF GitHub Bot commented on THRIFT-3253:
----------------------------------------

GitHub user phongphan opened a pull request:

    https://github.com/apache/thrift/pull/636

    THRIFT-3253

    Hi
    
    These changesets would fixed the deprecation warnings when compiling with latest D compiler. I have tested with 2.067.1.
    
    I have to change the `thriftToHashImpl` a bit in [379bac8] since I cannot get the `FieldNames` to work when using TMethodMeta.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/phongphan/thrift THRIFT-3253

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/636.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #636
    
----
commit f5e364523169daaef7b78f5edd21a2f2323e246c
Author: Phongphan Phuttha <ph...@acm.org>
Date:   2015-10-08T10:14:24Z

    THRIFT-3253 Replace deprecated Duration.fracSec with Duration.total

commit 5693dedc1389c580f0869f1b2007809afc5cc6a5
Author: Phongphan Phuttha <ph...@acm.org>
Date:   2015-10-08T11:25:48Z

    THRIFT-3253 Replace deprecated object.clear with object.destroy.

commit 379bac8229b156df184bf77656f2afc80e298fde
Author: Phongphan Phuttha <ph...@acm.org>
Date:   2015-10-08T12:46:49Z

    THRIFT-3253 Use tupleof for retrieving all fields in the class and its base class instead of FieldNames template

commit 78f494f35e3a8bad7941e5947025d932352b5a68
Author: Phongphan Phuttha <ph...@acm.org>
Date:   2015-10-08T12:55:18Z

    THRIFT-3253 Import missing hashset module

commit bbb7b44ff7a1743a98d02c4cc143e2e4ffbe3a0b
Author: Phongphan Phuttha <ph...@acm.org>
Date:   2015-10-08T13:00:31Z

    THRIFT-3253 Add missing testBool method

commit b59f43267b854be340d45d91b0be78d048356d72
Author: Phongphan Phuttha <ph...@acm.org>
Date:   2015-10-08T13:14:31Z

    THRIFT-3253 Replace deprecated object.clear with object.destroy

commit e98f4a2f328ecc9e1abb681357afe728c9866e2c
Author: Phongphan Phuttha <ph...@acm.org>
Date:   2015-10-08T13:15:10Z

    THRIFT-3253 Explicitly override toHash method to suppress the implicit overriding deprecation warning

----


> Using latest version of D gives deprecation notices
> ---------------------------------------------------
>
>                 Key: THRIFT-3253
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3253
>             Project: Thrift
>          Issue Type: Bug
>          Components: D - Library
>    Affects Versions: 0.9.2
>            Reporter: Jake Farrell
>
> src/thrift/transport/file.d(850): Deprecation: function core.time.Duration.fracSec is deprecated - Please use split instead.
> using deb from http://downloads.dlang.org/releases/2.x/2.067.1/dmd_2.067.1-0_amd64.deb



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)