You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by "davids5 (via GitHub)" <gi...@apache.org> on 2023/02/02 16:01:22 UTC

[GitHub] [nuttx] davids5 commented on a diff in pull request #8414: include: Add nitems() definition to sys/param.h

davids5 commented on code in PR #8414:
URL: https://github.com/apache/nuttx/pull/8414#discussion_r1094735675


##########
include/sys/param.h:
##########
@@ -43,6 +43,12 @@
 #  define MAX(a,b)      (((a) > (b)) ? (a) : (b))
 #endif  /* MAX */
 
+/* Macros for number of items. */
+
+#ifndef nitems

Review Comment:
   it was obvious  ARRAY_SIZE was macro when read in code. This look to be a function call.  It may not get found by someone adding code looking for and Array operation and then get duplicated again. 
   Can you use ARRAY_SIZE?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org