You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "qinliujie (GitHub)" <gi...@apache.org> on 2019/03/01 07:08:59 UTC
[GitHub] [incubator-dubbo] qinliujie opened pull request #3583:
[Feature] add AppendParametersComponent
## What is the purpose of the change
add AppendParametersComponent to dynamically add some parameters / check config
## Brief changelog
- add new SPI AppendParametersComponent
- when ServiceConfig/ReferenceConfig init, AppendParametersComponents will init and check
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3583 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] Jeff-Lv closed pull request #3583:
[Feature] add AppendParametersComponent
Posted by "Jeff-Lv (GitHub)" <gi...@apache.org>.
[ pull request closed by Jeff-Lv ]
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3583 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] codecov-io commented on issue #3583:
[Feature] add AppendParametersComponent
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3583?src=pr&el=h1) Report
> Merging [#3583](https://codecov.io/gh/apache/incubator-dubbo/pull/3583?src=pr&el=desc) into [3.x-dev](https://codecov.io/gh/apache/incubator-dubbo/commit/52c549e70f3685e860495f67c998456532be41ea?src=pr&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `83.33%`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/3583?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## 3.x-dev #3583 +/- ##
=============================================
+ Coverage 63.73% 63.77% +0.03%
Complexity 75 75
=============================================
Files 655 656 +1
Lines 28437 28449 +12
Branches 4812 4812
=============================================
+ Hits 18124 18143 +19
+ Misses 8033 8025 -8
- Partials 2280 2281 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3583?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/dubbo/config/AppendParametersComponent.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3583/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9BcHBlbmRQYXJhbWV0ZXJzQ29tcG9uZW50LmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [.../java/org/apache/dubbo/config/ReferenceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3583/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9SZWZlcmVuY2VDb25maWcuamF2YQ==) | `59.64% <100%> (+0.73%)` | `0 <0> (ø)` | :arrow_down: |
| [...in/java/org/apache/dubbo/config/ServiceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3583/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9TZXJ2aWNlQ29uZmlnLmphdmE=) | `55.23% <100%> (+0.47%)` | `0 <0> (ø)` | :arrow_down: |
| [...ache/dubbo/remoting/transport/AbstractChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3583/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RDaGFubmVsLmphdmE=) | `75% <0%> (-12.5%)` | `0% <0%> (ø)` | |
| [...apache/dubbo/common/config/ConfigurationUtils.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3583/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uZmlnL0NvbmZpZ3VyYXRpb25VdGlscy5qYXZh) | `40% <0%> (-8%)` | `0% <0%> (ø)` | |
| [...in/java/org/apache/dubbo/common/utils/JVMUtil.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3583/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvSlZNVXRpbC5qYXZh) | `73.58% <0%> (-7.55%)` | `0% <0%> (ø)` | |
| [...c/main/java/org/apache/dubbo/rpc/RpcException.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3583/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNFeGNlcHRpb24uamF2YQ==) | `82.75% <0%> (-3.45%)` | `0% <0%> (ø)` | |
| [...pache/dubbo/registry/support/AbstractRegistry.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3583/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9zdXBwb3J0L0Fic3RyYWN0UmVnaXN0cnkuamF2YQ==) | `80.07% <0%> (-2.26%)` | `0% <0%> (ø)` | |
| [...pache/dubbo/remoting/transport/AbstractServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3583/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RTZXJ2ZXIuamF2YQ==) | `48.95% <0%> (+1.04%)` | `0% <0%> (ø)` | :arrow_down: |
| ... and [7 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3583/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3583?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3583?src=pr&el=footer). Last update [52c549e...350c4f8](https://codecov.io/gh/apache/incubator-dubbo/pull/3583?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3583 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org