[jira] [Commented] (STORM-691) [storm-redis] Add basic lookup / persist bolts

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STORM-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357778#comment-14357778 ] 

ASF GitHub Bot commented on STORM-691:
--------------------------------------

Github user revans2 commented on the pull request:

    https://github.com/apache/storm/pull/451#issuecomment-78393165
  
    The code looks fine to me.  My only comment is that it would be nice to have a default in most of the case statements, mostly as defensive programming so if something gets off we wold get an error instead of falling through and ignoring the tuples.


> [storm-redis] Add basic lookup / persist bolts
> ----------------------------------------------
>
>                 Key: STORM-691
>                 URL: https://issues.apache.org/jira/browse/STORM-691
>             Project: Apache Storm
>          Issue Type: Improvement
>    Affects Versions: 0.10.0
>            Reporter: Jungtaek Lim
>            Assignee: Jungtaek Lim
>            Priority: Minor
>
> Currently storm-redis provides AbstractRedisBolt for normal (not Trident) Bolt.
> Jedis is easy to use so it may be enough, but we can also provide implementations of AbstractRedisBolt for simple usage.
> eg. store (key, value) pair, get key's value
> Since Redis has various data types and commands, we can't cover whole things, but seems like below things could be considered.
> || Type || Read || Write ||
> | STRING | GET (key) | SET (key, value) |
> | HASH | HGET (key, field) | HSET (key, field, value) |
> | LIST | LPOP (key) | RPUSH (key, value) |
> | SET | SCARD (key) | SADD (key, member) |
> | SORTED SET | ZSCORE (key, member) | ZADD (key, score, member) |
> | HLL (HyperLogLog) | PFCOUNT (key) | PFADD (key, element) |
> Btw, since we will normally get key & value from tuple (as most external module did), HASH, SET, SORTED SET needs additional key to process.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)