You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2021/02/17 15:22:54 UTC

[GitHub] [systemds] JustYeti32 opened a new pull request #1186: Initial commit

JustYeti32 opened a new pull request #1186:
URL: https://github.com/apache/systemds/pull/1186


   - tomek link implemented:
   * unsure if it can be invoked as desired
   
   - wrote test:
   * test shall write file from implemented
   * test shall write file from R-unbalanced implementation
   * unsure if can be invoked properly, only tested locally in console and R
   
   Additional Notes:
   - contains commented snippets to test for functionality. Need be removed later


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [systemds] JustYeti32 commented on pull request #1186: [DIA] TomekLink

Posted by GitBox <gi...@apache.org>.
JustYeti32 commented on pull request #1186:
URL: https://github.com/apache/systemds/pull/1186#issuecomment-788207527


   Thanks for the review and the adjustments! 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [systemds] JustYeti32 commented on pull request #1186: [DIA] TomekLink

Posted by GitBox <gi...@apache.org>.
JustYeti32 commented on pull request #1186:
URL: https://github.com/apache/systemds/pull/1186#issuecomment-786243333


   Everything apart from the missing "unbalanced" R-package should work. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [systemds] corepointer commented on pull request #1186: [DIA] TomekLink

Posted by GitBox <gi...@apache.org>.
corepointer commented on pull request #1186:
URL: https://github.com/apache/systemds/pull/1186#issuecomment-788093927


   Thanks again for your commit! I merged it as issue SYSTEMDS-2877 with minor formatting modifications (indentation).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [systemds] corepointer closed pull request #1186: [DIA] TomekLink

Posted by GitBox <gi...@apache.org>.
corepointer closed pull request #1186:
URL: https://github.com/apache/systemds/pull/1186


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org