You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by John Sirois <jo...@gmail.com> on 2016/01/05 00:34:12 UTC
Review Request 41899: Upgrade to pants 0.0.66.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41899/
-----------------------------------------------------------
Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
Repository: aurora
Description
-------
The changelog can be read here:
http://pantsbuild.github.io/changelog.html
Of note for aurora is the ability to kill BUILD.tools.
Additionally, add the pants generated .pids/ dir to .gitignore and
normalize all directory ignore to omit the redundant *.
.gitignore | 29 +++++++++++++++--------------
BUILD.tools | 18 ------------------
pants.ini | 2 +-
3 files changed, 16 insertions(+), 33 deletions(-)
Diffs
-----
.gitignore 12eff83938329f12ecd0a63043d8f34a608b7e94
BUILD.tools 2e237c43c47fda0771106cbf5a8cccb0b8147710
pants.ini 579d86cd2e02ea3e1a7add9cdd8291a6dc9669ec
Diff: https://reviews.apache.org/r/41899/diff/
Testing
-------
Locally green:
```
./build-support/jenkins/build.sh && ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
```
Thanks,
John Sirois
Re: Review Request 41899: Upgrade to pants 0.0.66.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41899/#review112730
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On Jan. 4, 2016, 3:34 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41899/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2016, 3:34 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The changelog can be read here:
> http://pantsbuild.github.io/changelog.html
>
> Of note for aurora is the ability to kill BUILD.tools.
>
> Additionally, add the pants generated .pids/ dir to .gitignore and
> normalize all directory ignore to omit the redundant *.
>
> .gitignore | 29 +++++++++++++++--------------
> BUILD.tools | 18 ------------------
> pants.ini | 2 +-
> 3 files changed, 16 insertions(+), 33 deletions(-)
>
>
> Diffs
> -----
>
> .gitignore 12eff83938329f12ecd0a63043d8f34a608b7e94
> BUILD.tools 2e237c43c47fda0771106cbf5a8cccb0b8147710
> pants.ini 579d86cd2e02ea3e1a7add9cdd8291a6dc9669ec
>
> Diff: https://reviews.apache.org/r/41899/diff/
>
>
> Testing
> -------
>
> Locally green:
> ```
> ./build-support/jenkins/build.sh && ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ```
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 41899: Upgrade to pants 0.0.66.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41899/#review112692
-----------------------------------------------------------
Ship it!
Ship It!
- Maxim Khutornenko
On Jan. 4, 2016, 11:34 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41899/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2016, 11:34 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The changelog can be read here:
> http://pantsbuild.github.io/changelog.html
>
> Of note for aurora is the ability to kill BUILD.tools.
>
> Additionally, add the pants generated .pids/ dir to .gitignore and
> normalize all directory ignore to omit the redundant *.
>
> .gitignore | 29 +++++++++++++++--------------
> BUILD.tools | 18 ------------------
> pants.ini | 2 +-
> 3 files changed, 16 insertions(+), 33 deletions(-)
>
>
> Diffs
> -----
>
> .gitignore 12eff83938329f12ecd0a63043d8f34a608b7e94
> BUILD.tools 2e237c43c47fda0771106cbf5a8cccb0b8147710
> pants.ini 579d86cd2e02ea3e1a7add9cdd8291a6dc9669ec
>
> Diff: https://reviews.apache.org/r/41899/diff/
>
>
> Testing
> -------
>
> Locally green:
> ```
> ./build-support/jenkins/build.sh && ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ```
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 41899: Upgrade to pants 0.0.66.
Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41899/#review112867
-----------------------------------------------------------
Ship it!
Ship It!
- Joshua Cohen
On Jan. 4, 2016, 11:34 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41899/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2016, 11:34 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The changelog can be read here:
> http://pantsbuild.github.io/changelog.html
>
> Of note for aurora is the ability to kill BUILD.tools.
>
> Additionally, add the pants generated .pids/ dir to .gitignore and
> normalize all directory ignore to omit the redundant *.
>
> .gitignore | 29 +++++++++++++++--------------
> BUILD.tools | 18 ------------------
> pants.ini | 2 +-
> 3 files changed, 16 insertions(+), 33 deletions(-)
>
>
> Diffs
> -----
>
> .gitignore 12eff83938329f12ecd0a63043d8f34a608b7e94
> BUILD.tools 2e237c43c47fda0771106cbf5a8cccb0b8147710
> pants.ini 579d86cd2e02ea3e1a7add9cdd8291a6dc9669ec
>
> Diff: https://reviews.apache.org/r/41899/diff/
>
>
> Testing
> -------
>
> Locally green:
> ```
> ./build-support/jenkins/build.sh && ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ```
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 41899: Upgrade to pants 0.0.66.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41899/#review112693
-----------------------------------------------------------
Ship it!
Master (8706a78) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Jan. 4, 2016, 11:34 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41899/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2016, 11:34 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The changelog can be read here:
> http://pantsbuild.github.io/changelog.html
>
> Of note for aurora is the ability to kill BUILD.tools.
>
> Additionally, add the pants generated .pids/ dir to .gitignore and
> normalize all directory ignore to omit the redundant *.
>
> .gitignore | 29 +++++++++++++++--------------
> BUILD.tools | 18 ------------------
> pants.ini | 2 +-
> 3 files changed, 16 insertions(+), 33 deletions(-)
>
>
> Diffs
> -----
>
> .gitignore 12eff83938329f12ecd0a63043d8f34a608b7e94
> BUILD.tools 2e237c43c47fda0771106cbf5a8cccb0b8147710
> pants.ini 579d86cd2e02ea3e1a7add9cdd8291a6dc9669ec
>
> Diff: https://reviews.apache.org/r/41899/diff/
>
>
> Testing
> -------
>
> Locally green:
> ```
> ./build-support/jenkins/build.sh && ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ```
>
>
> Thanks,
>
> John Sirois
>
>