You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by zy...@apache.org on 2012/11/08 18:03:09 UTC
git commit: TS-1564: Logs created via the API in plugins are not
rolled
Updated Branches:
refs/heads/master 50b007214 -> 6dadea4ce
TS-1564: Logs created via the API in plugins are not rolled
Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/6dadea4c
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/6dadea4c
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/6dadea4c
Branch: refs/heads/master
Commit: 6dadea4cea3da45e432dc52c7f9dadbf891b510a
Parents: 50b0072
Author: Craig Forbes <cf...@qualys.com>
Authored: Fri Nov 9 00:44:52 2012 +0800
Committer: Zhao Yongming <mi...@gmail.com>
Committed: Fri Nov 9 00:48:43 2012 +0800
----------------------------------------------------------------------
CHANGES | 2 ++
proxy/logging/LogObject.h | 3 +++
2 files changed, 5 insertions(+), 0 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/trafficserver/blob/6dadea4c/CHANGES
----------------------------------------------------------------------
diff --git a/CHANGES b/CHANGES
index 106ef3c..8a620a1 100644
--- a/CHANGES
+++ b/CHANGES
@@ -1,6 +1,8 @@
-*- coding: utf-8 -*-
Changes with Apache Traffic Server 3.3.1
+ *) [TS-1564] fix the rolling of Logs created via the API in plugins
+
*) [TS-1565] TSStringPercentEncode returns one character short in no-op case
(no encoding needed). Author: Thach Tran <tranngocthachs at gmail dot com>.
http://git-wip-us.apache.org/repos/asf/trafficserver/blob/6dadea4c/proxy/logging/LogObject.h
----------------------------------------------------------------------
diff --git a/proxy/logging/LogObject.h b/proxy/logging/LogObject.h
index b163696..141afa1 100644
--- a/proxy/logging/LogObject.h
+++ b/proxy/logging/LogObject.h
@@ -384,6 +384,9 @@ inline int LogObjectManager::roll_files(long time_now)
for (size_t i=0; i < _numObjects; i++) {
num_rolled += _objects[i]->roll_files(time_now);
}
+ for (size_t i=0; i < _numAPIobjects; i++) {
+ num_rolled += _APIobjects[i]->roll_files(time_now);
+ }
return num_rolled;
};
Re: git commit: TS-1564: Logs created via the API in plugins are
not rolled
Posted by Leif Hedstrom <zw...@apache.org>.
On 11/9/12 12:52 AM, Igor Galić wrote:
>
> ----- Original Message -----
>> hmm, I have put him in the author of git commit:
>>
>> commit 6dadea4cea3da45e432dc52c7f9dadbf891b510a
>> Author: Craig Forbes <cf...@qualys.com>
>> Date: Fri Nov 9 00:44:52 2012 +0800
>>
>> TS-1564: Logs created via the API in plugins are not rolled
>>
>> should we strict on the style? which one is prefer then?
> Seen that. Now went back and realized that a lot more
> CHANGES lines were missing that. So I'd say we're doing
> "best effort" - now ignore me again and do something
> productive ;)
>
I personally always put the Author: in the Changes file, when I'm committing
on behalf of a non-committer. It's the file that ships with our
distributions. My vote would be to always do this, but only when the Author
is not an ATS committer.
-- Leif
Re: git commit: TS-1564: Logs created via the API in plugins are
not rolled
Posted by Igor Galić <i....@brainsware.org>.
----- Original Message -----
> hmm, I have put him in the author of git commit:
>
> commit 6dadea4cea3da45e432dc52c7f9dadbf891b510a
> Author: Craig Forbes <cf...@qualys.com>
> Date: Fri Nov 9 00:44:52 2012 +0800
>
> TS-1564: Logs created via the API in plugins are not rolled
>
> should we strict on the style? which one is prefer then?
Seen that. Now went back and realized that a lot more
CHANGES lines were missing that. So I'd say we're doing
"best effort" - now ignore me again and do something
productive ;)
i
--
Igor Galić
Tel: +43 (0) 664 886 22 883
Mail: i.galic@brainsware.org
URL: http://brainsware.org/
GPG: 6880 4155 74BD FD7C B515 2EA5 4B1D 9E08 A097 C9AE
Re: git commit: TS-1564: Logs created via the API in plugins are
not rolled
Posted by "ming.zym@gmail.com" <mi...@gmail.com>.
hmm, I have put him in the author of git commit:
commit 6dadea4cea3da45e432dc52c7f9dadbf891b510a
Author: Craig Forbes <cf...@qualys.com>
Date: Fri Nov 9 00:44:52 2012 +0800
TS-1564: Logs created via the API in plugins are not rolled
should we strict on the style? which one is prefer then?
在 2012-11-09五的 00:01 +0000，Igor Galić写道：
> > diff --git a/CHANGES b/CHANGES
> > index 106ef3c..8a620a1 100644
> > --- a/CHANGES
> > +++ b/CHANGES
> > @@ -1,6 +1,8 @@
> > -*- coding:
> > utf-8 -*-
> > Changes with Apache Traffic Server 3.3.1
> >
> > + *) [TS-1564] fix the rolling of Logs created via the API in
> > plugins
> > +
>
> This is missing the crediting of the original author.
>
> > *) [TS-1565] TSStringPercentEncode returns one character short in
> > no-op case
> > (no encoding needed). Author: Thach Tran <tranngocthachs at
> > gmail dot com>.
> >
> >
> > http://git-wip-us.apache.org/repos/asf/trafficserver/blob/6dadea4c/proxy/logging/LogObject.h
> > ----------------------------------------------------------------------
> > diff --git a/proxy/logging/LogObject.h b/proxy/logging/LogObject.h
> > index b163696..141afa1 100644
> > --- a/proxy/logging/LogObject.h
> > +++ b/proxy/logging/LogObject.h
> > @@ -384,6 +384,9 @@ inline int LogObjectManager::roll_files(long
> > time_now)
> > for (size_t i=0; i < _numObjects; i++) {
> > num_rolled += _objects[i]->roll_files(time_now);
> > }
> > + for (size_t i=0; i < _numAPIobjects; i++) {
> > + num_rolled += _APIobjects[i]->roll_files(time_now);
> > + }
> > return num_rolled;
> > };
> >
> >
> >
>
> i
>
Re: git commit: TS-1564: Logs created via the API in plugins are
not rolled
Posted by Igor Galić <i....@brainsware.org>.
> diff --git a/CHANGES b/CHANGES
> index 106ef3c..8a620a1 100644
> --- a/CHANGES
> +++ b/CHANGES
> @@ -1,6 +1,8 @@
> -*- coding:
> utf-8 -*-
> Changes with Apache Traffic Server 3.3.1
>
> + *) [TS-1564] fix the rolling of Logs created via the API in
> plugins
> +
This is missing the crediting of the original author.
> *) [TS-1565] TSStringPercentEncode returns one character short in
> no-op case
> (no encoding needed). Author: Thach Tran <tranngocthachs at
> gmail dot com>.
>
>
> http://git-wip-us.apache.org/repos/asf/trafficserver/blob/6dadea4c/proxy/logging/LogObject.h
> ----------------------------------------------------------------------
> diff --git a/proxy/logging/LogObject.h b/proxy/logging/LogObject.h
> index b163696..141afa1 100644
> --- a/proxy/logging/LogObject.h
> +++ b/proxy/logging/LogObject.h
> @@ -384,6 +384,9 @@ inline int LogObjectManager::roll_files(long
> time_now)
> for (size_t i=0; i < _numObjects; i++) {
> num_rolled += _objects[i]->roll_files(time_now);
> }
> + for (size_t i=0; i < _numAPIobjects; i++) {
> + num_rolled += _APIobjects[i]->roll_files(time_now);
> + }
> return num_rolled;
> };
>
>
>
i
--
Igor Galić
Tel: +43 (0) 664 886 22 883
Mail: i.galic@brainsware.org
URL: http://brainsware.org/
GPG: 6880 4155 74BD FD7C B515 2EA5 4B1D 9E08 A097 C9AE