You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by ahgittin <no...@github.com> on 2014/01/08 16:12:39 UTC
[jclouds] JCLOUDS-213: Fixing SoftLayer support (#248)
Forward port of f278450355bbaa95c841c2f857a528091b90d723, updated for 1.7.0 naming convention (Api instead of *Client)
Conflicts: (All are just around the naming change mentioned above.)
providers/softlayer/src/main/java/org/jclouds/softlayer/compute/config/SoftLayerComputeServiceContextModule.java
providers/softlayer/src/main/java/org/jclouds/softlayer/features/AccountAsyncClient.java
providers/softlayer/src/main/java/org/jclouds/softlayer/features/AccountClient.java
providers/softlayer/src/test/java/org/jclouds/softlayer/features/BaseSoftLayerApiLiveTest.java
providers/softlayer/src/test/java/org/jclouds/softlayer/features/ProductPackageApiLiveTest.java
providers/softlayer/src/test/java/org/jclouds/softlayer/features/VirtualGuestApiLiveTest.java
You can merge this Pull Request by running:
git pull https://github.com/ahgittin/jclouds JCLOUDS-213-forward-port-to-1.8
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/248
-- Commit Summary --
* JCLOUDS-213: Fixing SoftLayer support
-- File Changes --
M providers/softlayer/src/main/java/org/jclouds/softlayer/SoftLayerProviderMetadata.java (2)
M providers/softlayer/src/main/java/org/jclouds/softlayer/compute/config/SoftLayerComputeServiceContextModule.java (2)
M providers/softlayer/src/main/java/org/jclouds/softlayer/compute/functions/ProductItemToImage.java (23)
M providers/softlayer/src/main/java/org/jclouds/softlayer/compute/functions/ProductItems.java (8)
M providers/softlayer/src/main/java/org/jclouds/softlayer/compute/functions/VirtualGuestToNodeMetadata.java (6)
M providers/softlayer/src/main/java/org/jclouds/softlayer/domain/ProductOrder.java (2)
M providers/softlayer/src/main/java/org/jclouds/softlayer/features/AccountApi.java (13)
M providers/softlayer/src/test/java/org/jclouds/softlayer/compute/SoftLayerComputeServiceAdapterLiveTest.java (12)
M providers/softlayer/src/test/java/org/jclouds/softlayer/compute/SoftLayerComputeServiceLiveTest.java (19)
M providers/softlayer/src/test/java/org/jclouds/softlayer/compute/SoftLayerTemplateBuilderLiveTest.java (10)
M providers/softlayer/src/test/java/org/jclouds/softlayer/compute/functions/ProductItemToImageTest.java (38)
M providers/softlayer/src/test/java/org/jclouds/softlayer/features/AccountApiLiveTest.java (10)
A providers/softlayer/src/test/java/org/jclouds/softlayer/features/AccountClientExpectTest.java (129)
M providers/softlayer/src/test/java/org/jclouds/softlayer/features/BaseSoftLayerApiLiveTest.java (35)
M providers/softlayer/src/test/java/org/jclouds/softlayer/features/DatacenterApiLiveTest.java (17)
M providers/softlayer/src/test/java/org/jclouds/softlayer/features/ProductPackageApiLiveTest.java (38)
M providers/softlayer/src/test/java/org/jclouds/softlayer/features/VirtualGuestApiLiveTest.java (74)
A providers/softlayer/src/test/resources/get_active_packages.json (38287)
A providers/softlayer/src/test/resources/get_reduced_active_packages.json (10)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/248.patch
https://github.com/jclouds/jclouds/pull/248.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/248
Re: [jclouds] JCLOUDS-213: Fixing SoftLayer support (#248)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1077](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1077/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/248#issuecomment-35296322
Re: [jclouds] JCLOUDS-213: Fixing SoftLayer support (#248)
Posted by ahgittin <no...@github.com>.
actually this is rendered obsolete by #296 - closing - but please look at #296 !
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/248#issuecomment-36608387
Re: [jclouds] JCLOUDS-213: Fixing SoftLayer support (#248)
Posted by Andrew Phillips <no...@github.com>.
Closed #248.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/248#event-138000305
Re: [jclouds] JCLOUDS-213: Fixing SoftLayer support (#248)
Posted by ahgittin <no...@github.com>.
@demobox @nacx now that checkstyle is fixed can we merge this?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/248#issuecomment-36606973
Re: [jclouds] JCLOUDS-213: Fixing SoftLayer support (#248)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #726](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/726/) UNSTABLE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/248#issuecomment-31852485
Re: [jclouds] JCLOUDS-213: Fixing SoftLayer support (#248)
Posted by Andrew Phillips <no...@github.com>.
+1 - looks good to me. Let's see what the other PR builders say.
> jclouds » jclouds #726 UNSTABLE
This [test failure](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/org.apache.jclouds$jclouds-core/726/testReport/junit/org.jclouds.rest.functions/PresentWhenApiVersionLexicographicallyAtOrAfterSinceApiVersionTest/testCacheIsFasterWhenAnnotationPresent/) is unrelated.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/248#issuecomment-31860898
Re: [jclouds] JCLOUDS-213: Fixing SoftLayer support (#248)
Posted by Andrew Phillips <no...@github.com>.
> this is rendered obsolete by #296 - closing - but ...
@ahgittin This is still open? Is that intentional?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/248#issuecomment-36636677
Re: [jclouds] JCLOUDS-213: Fixing SoftLayer support (#248)
Posted by Andrew Phillips <no...@github.com>.
The problem with [style violations](https://github.com/jclouds/jclouds/pull/247#issuecomment-31861143) in #247 probably also applies here?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/248#issuecomment-31861213
Re: [jclouds] JCLOUDS-213: Fixing SoftLayer support (#248)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #606](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/606/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/248#issuecomment-35296404
Re: [jclouds] JCLOUDS-213: Fixing SoftLayer support (#248)
Posted by Andrew Phillips <no...@github.com>.
> Can this PR be closed?
Closing...we can always reopen if necessary ;-) Thanks for checking, @jdaggett!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/248#issuecomment-47956759
Re: [jclouds] JCLOUDS-213: Fixing SoftLayer support (#248)
Posted by Jeremy Daggett <no...@github.com>.
@ahgittin Can this PR be closed?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/248#issuecomment-47953119