You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/02/17 16:40:04 UTC

[GitHub] [ozone] bshashikant opened a new pull request #1932: HDDS-4660. Update OMTransactionInfo to TransactionInfo with functions added

bshashikant opened a new pull request #1932:
URL: https://github.com/apache/ozone/pull/1932


   
   ## What changes were proposed in this pull request?
   Refactoring change for OMTransactionInfo/SCMTransactionInfo
   
   ## What is the link to the Apache JIRA
   https://github.com/apache/ozone/pull/1833
   
   ## How was this patch tested?
   
   Refactoring change, Existing unit tests should suffice.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] bshashikant commented on pull request #1932: HDDS-4660. Merge OMTransactionInfo with SCMTransactionInfo

Posted by GitBox <gi...@apache.org>.
bshashikant commented on pull request #1932:
URL: https://github.com/apache/ozone/pull/1932#issuecomment-781084108


   Thanks @amaliujia for the review. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] bshashikant merged pull request #1932: HDDS-4660. Merge OMTransactionInfo with SCMTransactionInfo

Posted by GitBox <gi...@apache.org>.
bshashikant merged pull request #1932:
URL: https://github.com/apache/ozone/pull/1932


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] amaliujia commented on a change in pull request #1932: HDDS-4660. Merge OMTransactionInfo with SCMTransactionInfo

Posted by GitBox <gi...@apache.org>.
amaliujia commented on a change in pull request #1932:
URL: https://github.com/apache/ozone/pull/1932#discussion_r578133370



##########
File path: hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/TransactionInfo.java
##########
@@ -159,9 +186,8 @@ public Builder setTransactionIndex(long tIndex) {
       return this;
     }
 
-    public OMTransactionInfo build() {
-      return new OMTransactionInfo(currentTerm, transactionIndex);
+    public TransactionInfo build() {
+      return new TransactionInfo(currentTerm, transactionIndex);
     }
-

Review comment:
       nit: undo this line

##########
File path: hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/DBStoreHAManager.java
##########
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hdds.utils;
+
+import org.apache.hadoop.hdds.utils.db.Table;
+
+/**
+ * Interface defined for getting HA related specific info from DB for SCM and
+ * OM.
+ */
+public interface DBStoreHAManager {
+
+  default Table<String, TransactionInfo> getTransactionInfoTable() {

Review comment:
       +1 I was actually stuck on this one: I wasn't sure how to deal with this class in OM.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org