You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/09 03:51:13 UTC

[GitHub] [spark] gengliangwang edited a comment on pull request #35379: [SPARK-38091][SQL] fix bugs in AvroSerializer

gengliangwang edited a comment on pull request #35379:
URL: https://github.com/apache/spark/pull/35379#issuecomment-1033255310


   > do you know if we encourage/discourage formatting-only PRs to make code format match the expectation from ./dev/scalafmt
   
   @xkrogen @Zhen-hao In general we don't do that. 
   Instead, people follow https://github.com/databricks/scala-style-guide and create clean patches.
   
   ============= update after I try ./dev/scalafmt ===========
   @Zhen-hao I tried ./dev/scalafmt and the tool only formatted my changed lines, which is expected. 
   In the PR, it seems that the whole file is reformatted. Could you double check it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org