You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by "James E. King III (JIRA)" <ji...@apache.org> on 2019/01/24 22:03:00 UTC

[jira] [Commented] (THRIFT-4019) Dart Makefiles should also clean pubspec.lock

    [ https://issues.apache.org/jira/browse/THRIFT-4019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16751626#comment-16751626 ] 

James E. King III commented on THRIFT-4019:
-------------------------------------------

Hi, in other languages you actually check in the lock file (js, npm, etc) because that makes your build stable.  Are we sure we should be deleting and gitignoring this file?  I'm thinking we should be checking it in...

> Dart Makefiles should also clean pubspec.lock
> ---------------------------------------------
>
>                 Key: THRIFT-4019
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4019
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Build Process
>            Reporter: Mark Erickson
>            Assignee: Mark Erickson
>            Priority: Major
>             Fix For: 0.10.0
>
>
> Dart pub get produces a pubspec.lock file, which is git-ignored.  These should be removed as part of `make clean`.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)