[GitHub] [apisix] starsz commented on a diff in pull request #9116: feat: Add feature to check for stream route references when deleting and implement protocol matching

["starsz (via GitHub)" <gi...@apache.org>]

starsz commented on code in PR #9116:
URL: https://github.com/apache/apisix/pull/9116#discussion_r1142948519


##########
apisix/stream/router/ip_port.lua:
##########
@@ -78,9 +78,30 @@ do
 
             local route = item.value
             if route.protocol and route.protocol.superior_id then
-                -- subordinate route won't be matched in the entry
-                -- TODO: check the subordinate relationship in the Admin API
-                goto CONTINUE
+                local admin_api = require("apisix.admin").check_http_admin()
+                if not admin_api then
+                    ngx.log(ngx.ERR, "failed to get http admin node")

Review Comment:
   Can we use "core.log" instead?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org