You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by ceharris <gi...@git.apache.org> on 2017/10/09 11:09:10 UTC
[GitHub] incubator-guacamole-manual pull request #58: WIP: GUACAMOLE-406: Add documen...
GitHub user ceharris opened a pull request:
https://github.com/apache/incubator-guacamole-manual/pull/58
WIP: GUACAMOLE-406: Add documentation for event listener support
I think this is at a point where some review would be helpful. Would appreciate feedback on the content itself (especially level of detail, illustrative value of the examples, etc), placement in the user manual structure, as well as any syntactic issues.
There is some repetition between this section and the section on custom authentication providers. In particular, the instructions for installing a custom extension are duplicated almost verbatim. Perhaps this would be better addressed in the chapter on guacamole-ext or elsewhere.
Much of the skeleton for the example itself is also very similar to the authentication provider example, but I think this is probably to be expected and may not be a bad thing.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/soulwing/incubator-guacamole-manual GUACAMOLE-406
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-guacamole-manual/pull/58.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #58
----
commit 6908176913560d0480ff9a6951b8caafbf92f3c3
Author: Carl Harris <ce...@vt.edu>
Date: 2017-10-08T13:54:25Z
GUACAMOLE-409: add Dockerfile and .dockerignore
commit 47037238642be4f630db0b630caf038896b52b72
Author: Carl Harris <ce...@vt.edu>
Date: 2017-10-08T13:54:53Z
GUACAMOLE-409: include instructions for using Dockerfile in README
commit c6bafbb2343a10d41e95b4ee3e7ee268e5121949
Author: Carl Harris <ce...@vt.edu>
Date: 2017-10-08T18:11:41Z
GUACAMOLE-406: first draft of event listener chapter
commit 46c2a945a1b0f1561a42813dbdda40f5849d4f88
Author: Carl Harris <ce...@vt.edu>
Date: 2017-10-08T18:12:18Z
GUACAMOLE-406: document new listeners manifest property
commit 22010c26149bfd0c1421033ed13843a5ff1ed808
Author: Carl Harris <ce...@vt.edu>
Date: 2017-10-08T18:13:31Z
GUACAMOLE-406: link event listener chapter into user guide
commit 11d868a4093d3cf8aa909bc814c16bbcc683ddd5
Author: Carl Harris <ce...@vt.edu>
Date: 2017-10-09T10:59:12Z
GUACAMOLE-406: revisions based on proofreading
----
---
[GitHub] incubator-guacamole-manual pull request #58: WIP: GUACAMOLE-406: Add documen...
Posted by ceharris <gi...@git.apache.org>.
Github user ceharris closed the pull request at:
https://github.com/apache/incubator-guacamole-manual/pull/58
---