[GitHub] spark pull request #14079: [SPARK-8425][CORE] New Blacklist Mechanism

[kayousterhout <gi...@git.apache.org>]

Github user kayousterhout commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14079#discussion_r77250600
  
    --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala ---
    @@ -90,6 +92,54 @@ package object config {
         .toSequence
         .createWithDefault(Nil)
     
    +  // Blacklist confs
    +  private[spark] val BLACKLIST_ENABLED =
    +    ConfigBuilder("spark.blacklist.enabled")
    +      .booleanConf
    +      .createOptional
    +
    +  private[spark] val MAX_TASK_ATTEMPTS_PER_EXECUTOR =
    +    ConfigBuilder("spark.blacklist.task.maxTaskAttemptsPerExecutor")
    +      .intConf
    +      .createWithDefault(1)
    +
    +  private[spark] val MAX_TASK_ATTEMPTS_PER_NODE =
    +    ConfigBuilder("spark.blacklist.task.maxTaskAttemptsPerNode")
    --- End diff --
    
    Why is this one "maxTaskAttempts" whereas the others are "maxFailedTasks"? (apologies if we already discussed this... I know we've had lots of naming discussions)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org