[GitHub] [dubbo] aftersss opened pull request #4877: Speed up registry destroy.

["aftersss (GitHub)" <gi...@apache.org>]

When we shutdown our program, we found that it costs too much time at destroying registry from zookeeper. Consider that if we have 200 urls registered to zookeeper, and every unregister will cost 100ms, it will cost 200*100 = 20000ms to shutdown the program.

This PR uses a thread pool to reduce the shutdown time.

[ Full content available at: https://github.com/apache/dubbo/pull/4877 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo] chickenlj commented on issue #4877: Speed up registry destroy.

["chickenlj (GitHub)" <gi...@apache.org>]

How about the batch operation of zookeeper, have you ever tried?

[ Full content available at: https://github.com/apache/dubbo/pull/4877 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo] chickenlj commented on issue #4877: Speed up registry destroy.

["chickenlj (GitHub)" <gi...@apache.org>]

Please solve the conflicts and reopen.

More importantly, I am not sure if there are any side effects if we make the unregister process parallel and async.

[ Full content available at: https://github.com/apache/dubbo/pull/4877 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org