You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by rx...@apache.org on 2016/04/21 09:31:08 UTC
spark git commit: [SPARK-14794][SQL] Don't pass analyze command into
Hive
Repository: spark
Updated Branches:
refs/heads/master 3b9fd5173 -> 228128ce2
[SPARK-14794][SQL] Don't pass analyze command into Hive
## What changes were proposed in this pull request?
We shouldn't pass analyze command to Hive because some of those would require running MapReduce jobs. For now, let's just always run the no scan analyze.
## How was this patch tested?
Updated test case to reflect this change.
Author: Reynold Xin <rx...@databricks.com>
Closes #12558 from rxin/parser-analyze.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/228128ce
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/228128ce
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/228128ce
Branch: refs/heads/master
Commit: 228128ce2571c3058cb13ae502a5328745eeeef5
Parents: 3b9fd51
Author: Reynold Xin <rx...@databricks.com>
Authored: Thu Apr 21 00:31:06 2016 -0700
Committer: Reynold Xin <rx...@databricks.com>
Committed: Thu Apr 21 00:31:06 2016 -0700
----------------------------------------------------------------------
.../apache/spark/sql/hive/execution/HiveSqlParser.scala | 4 +++-
.../scala/org/apache/spark/sql/hive/StatisticsSuite.scala | 10 +++++-----
2 files changed, 8 insertions(+), 6 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/228128ce/sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveSqlParser.scala
----------------------------------------------------------------------
diff --git a/sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveSqlParser.scala b/sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveSqlParser.scala
index 00f829d..1c4cda7 100644
--- a/sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveSqlParser.scala
+++ b/sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveSqlParser.scala
@@ -77,7 +77,9 @@ class HiveSqlAstBuilder(conf: SQLConf) extends SparkSqlAstBuilder(conf) {
ctx.identifier.getText.toLowerCase == "noscan") {
AnalyzeTable(visitTableIdentifier(ctx.tableIdentifier).toString)
} else {
- HiveNativeCommand(command(ctx))
+ // Always just run the no scan analyze. We should fix this and implement full analyze
+ // command in the future.
+ AnalyzeTable(visitTableIdentifier(ctx.tableIdentifier).toString)
}
}
http://git-wip-us.apache.org/repos/asf/spark/blob/228128ce/sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala
----------------------------------------------------------------------
diff --git a/sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala b/sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala
index adc7af3..e918704 100644
--- a/sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala
+++ b/sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala
@@ -49,19 +49,19 @@ class StatisticsSuite extends QueryTest with TestHiveSingleton {
assertAnalyzeCommand(
"ANALYZE TABLE Table1 COMPUTE STATISTICS",
- classOf[HiveNativeCommand])
+ classOf[AnalyzeTable])
assertAnalyzeCommand(
"ANALYZE TABLE Table1 PARTITION(ds='2008-04-09', hr=11) COMPUTE STATISTICS",
- classOf[HiveNativeCommand])
+ classOf[AnalyzeTable])
assertAnalyzeCommand(
"ANALYZE TABLE Table1 PARTITION(ds='2008-04-09', hr=11) COMPUTE STATISTICS noscan",
- classOf[HiveNativeCommand])
+ classOf[AnalyzeTable])
assertAnalyzeCommand(
"ANALYZE TABLE Table1 PARTITION(ds, hr) COMPUTE STATISTICS",
- classOf[HiveNativeCommand])
+ classOf[AnalyzeTable])
assertAnalyzeCommand(
"ANALYZE TABLE Table1 PARTITION(ds, hr) COMPUTE STATISTICS noscan",
- classOf[HiveNativeCommand])
+ classOf[AnalyzeTable])
assertAnalyzeCommand(
"ANALYZE TABLE Table1 COMPUTE STATISTICS nOscAn",
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org