You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/10/21 07:08:54 UTC

[GitHub] [pulsar] wangjialing218 opened a new pull request #12450: [Sink] fix updateSink fail to update cleanupSubscription

wangjialing218 opened a new pull request #12450:
URL: https://github.com/apache/pulsar/pull/12450


   ### Motivation
   
   call updateSink miss to update  `cleanupSubscription`
   
   ### Modifications
   
   update  `cleanupSubscription` in `validateUpdate()`
   
   ### Verifying this change
   This change added tests and can be verified as follows:
   `SinkConfigUtilsTest.testMergeDifferentCleanupSubscription()`
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (o)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation  
   - [ ] `no-need-doc` 
      only bug fix.
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] wangjialing218 commented on pull request #12450: [Sink] fix updateSink and getSinkInfo miss to handle cleanupSubscription

Posted by GitBox <gi...@apache.org>.
wangjialing218 commented on pull request #12450:
URL: https://github.com/apache/pulsar/pull/12450#issuecomment-986571520


   @eolivelli @codelipenghui could you help to review this pr


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli commented on pull request #12450: [Sink] fix updateSink fail to update cleanupSubscription

Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #12450:
URL: https://github.com/apache/pulsar/pull/12450#issuecomment-948328923


   @wangjialing218:Thanks for providing doc info!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] murong00 merged pull request #12450: [Sink] fix updateSink and getSinkInfo miss to handle cleanupSubscription

Posted by GitBox <gi...@apache.org>.
murong00 merged pull request #12450:
URL: https://github.com/apache/pulsar/pull/12450


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli commented on pull request #12450: [Sink] fix updateSink fail to update cleanupSubscription

Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #12450:
URL: https://github.com/apache/pulsar/pull/12450#issuecomment-948320813


   @wangjialing218:Thanks for your contribution. For this PR, do we need to update docs?
   (The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] wangjialing218 commented on pull request #12450: [Sink] fix updateSink fail to update cleanupSubscription

Posted by GitBox <gi...@apache.org>.
wangjialing218 commented on pull request #12450:
URL: https://github.com/apache/pulsar/pull/12450#issuecomment-948329889


   @eolivelli For this PR, no need to update documents, only bug fix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] wangjialing218 commented on pull request #12450: [Sink] fix updateSink and getSinkInfo miss to handle cleanupSubscription

Posted by GitBox <gi...@apache.org>.
wangjialing218 commented on pull request #12450:
URL: https://github.com/apache/pulsar/pull/12450#issuecomment-948428347


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org