[GitHub] [kafka] lbradstreet commented on a change in pull request #11230: KAFKA-12840; Removing `compact` cleaning on a topic should abort on-going compactions

[GitBox <gi...@apache.org>]

lbradstreet commented on a change in pull request #11230:
URL: https://github.com/apache/kafka/pull/11230#discussion_r691368381



##########
File path: core/src/main/scala/kafka/server/ConfigHandler.scala
##########
@@ -66,8 +66,13 @@ class TopicConfigHandler(private val logManager: LogManager, kafkaConfig: KafkaC
       topicConfig.asScala.forKeyValue { (key, value) =>
         if (!configNamesToExclude.contains(key)) props.put(key, value)
       }
-      val logConfig = LogConfig.fromProps(logManager.currentDefaultConfig.originals, props)
-      logs.foreach(_.updateConfig(logConfig))
+      val newLogConfig = LogConfig.fromProps(logManager.currentDefaultConfig.originals, props)

Review comment:
       I assume we're doing this here because Log doesn't have access to the log manager? Would it be better to have the comparison logic in the LogManager where it'll be more visible, e.g. maybeAbortCleaning(oldConfig, newConfig)?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org