You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/10/19 07:49:37 UTC

[GitHub] [shardingsphere] tuichenchuxin opened a new issue #13131: support parsing SHOW PROCEDURE STATUS for mysql

tuichenchuxin opened a new issue #13131:
URL: https://github.com/apache/shardingsphere/issues/13131


   Hi community,
   
   This issue can be a good first try.
   
   ## Aim
   support parse mysql administration statements sql `SHOW PROCEDURE STATUS`
   
   ## Basic Qualifications
   - java
   - maven
   - antlr4
   
   ## Detail
   We have completed the clone rule in DALStatement.g4.
   But have not yet implement the visit method in `shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/mysql/visitor/statement/impl/MySQLDALStatementSQLVisitor.java`
   To complete this issue, I think we should complete these steps:
   - Create `MySQLShowProcedureStatusStatement` class in this package `org.apache.shardingsphere.sql.parser.sql.dialect.statement.mysql.dal`
   - Add rule for clone in `shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/database/visitor/SQLVisitorRule.java`
   - Implement the visit method in `shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/mysql/visitor/statement/impl/MySQLDALStatementSQLVisitor.java`. 
   - Finally, add test for parse clone statement in `shardingsphere-test` module
   ## Example FYI
   - Refer to this merged pr：https://github.com/apache/shardingsphere/pull/12979/files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tuichenchuxin commented on issue #13131: support parsing SHOW PROCEDURE STATUS for mysql

Posted by GitBox <gi...@apache.org>.
tuichenchuxin commented on issue #13131:
URL: https://github.com/apache/shardingsphere/issues/13131#issuecomment-947348198


   @ThanoshanMV You can use this code to test it.
   https://github.com/apache/shardingsphere/blob/837b14ff0657cd59673de25f31cb48c02a9e1088/examples/other-example/shardingsphere-parser-example/src/main/java/org/apache/shardingsphere/example/parser/mysql/statement/MySQLParserStatementExample.java


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tuichenchuxin commented on issue #13131: support parsing SHOW PROCEDURE STATUS for mysql

Posted by GitBox <gi...@apache.org>.
tuichenchuxin commented on issue #13131:
URL: https://github.com/apache/shardingsphere/issues/13131#issuecomment-968933629


   @flycash yes,it has been completed, I'll close it, thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tuichenchuxin closed issue #13131: support parsing SHOW PROCEDURE STATUS for mysql

Posted by GitBox <gi...@apache.org>.
tuichenchuxin closed issue #13131:
URL: https://github.com/apache/shardingsphere/issues/13131


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] ThanoshanMV commented on issue #13131: support parsing SHOW PROCEDURE STATUS for mysql

Posted by GitBox <gi...@apache.org>.
ThanoshanMV commented on issue #13131:
URL: https://github.com/apache/shardingsphere/issues/13131#issuecomment-949300435


   Thank you @tuichenchuxin.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] ThanoshanMV commented on issue #13131: support parsing SHOW PROCEDURE STATUS for mysql

Posted by GitBox <gi...@apache.org>.
ThanoshanMV commented on issue #13131:
URL: https://github.com/apache/shardingsphere/issues/13131#issuecomment-946771826


   Hi @tuichenchuxin, could you please let me know how can I reproduce this parsing failure.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] flycash commented on issue #13131: support parsing SHOW PROCEDURE STATUS for mysql

Posted by GitBox <gi...@apache.org>.
flycash commented on issue #13131:
URL: https://github.com/apache/shardingsphere/issues/13131#issuecomment-968897825


   I found that there was already `MySQLShowProcedureStatusStatement`, so it was addressed, right?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org