You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2022/11/14 08:20:30 UTC
[Bug 66347] New: Add theme support to XWPF
https://bz.apache.org/bugzilla/show_bug.cgi?id=66347
Bug ID: 66347
Summary: Add theme support to XWPF
Product: POI
Version: unspecified
Hardware: PC
OS: Mac OS X 10.1
Status: NEW
Severity: normal
Priority: P2
Component: XWPF
Assignee: dev@poi.apache.org
Reporter: stephan.schwiebert@gmail.com
Target Milestone: ---
Created attachment 38433
--> https://bz.apache.org/bugzilla/attachment.cgi?id=38433&action=edit
Adding XWPFTheme
While XSLF already has support for 'themes' via XSLFTheme, there is no
counterpart for XWPF yet. The patch on this tickets adds XWPFTheme (the
implementation is mostly copied from XSLFTheme, since there's not much
difference between them).
Please let me know what you're thinking!
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 66347] Add theme support to XWPF
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66347
--- Comment #2 from stephan.schwiebert@gmail.com ---
Sure, I'll add some tests. Thanks!
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 66347] Add theme support to XWPF
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66347
--- Comment #3 from stephan.schwiebert@gmail.com ---
Created attachment 38435
--> https://bz.apache.org/bugzilla/attachment.cgi?id=38435&action=edit
Basic test for XWPF themes
Added a small test case to verify that a theme can be read.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
Re: [Bug 66347] Add theme support to XWPF
Posted by Kamal Chandrashekar <sa...@gmail.com>.
Update shall we see.
On Tue, 22 Nov, 2022, 1:46 am , <bu...@apache.org> wrote:
> https://bz.apache.org/bugzilla/show_bug.cgi?id=66347
>
> --- Comment #5 from stephan.schwiebert@gmail.com ---
> Sorry, I should have mentioned that in the previous comment.
>
> I was considering a test for modifying a theme, but the "XWPFTheme"
> implementation is based on/aligned with the existing "XSLFTheme", which
> doesn't
> provide methods to modify the theme (besides going through
> "getXmlObject()",
> but that seems to be an internal method).
>
> I agree that it would be nice to be able to modify themes (for XSLF and
> XWPF),
> but it seemed to me like that's out of scope of this patch. Or do you think
> differently?
>
> --
> You are receiving this mail because:
> You are the assignee for the bug.
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
> For additional commands, e-mail: dev-help@poi.apache.org
>
>
[Bug 66347] Add theme support to XWPF
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66347
--- Comment #5 from stephan.schwiebert@gmail.com ---
Sorry, I should have mentioned that in the previous comment.
I was considering a test for modifying a theme, but the "XWPFTheme"
implementation is based on/aligned with the existing "XSLFTheme", which doesn't
provide methods to modify the theme (besides going through "getXmlObject()",
but that seems to be an internal method).
I agree that it would be nice to be able to modify themes (for XSLF and XWPF),
but it seemed to me like that's out of scope of this patch. Or do you think
differently?
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 66347] Add theme support to XWPF
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66347
PJ Fanning <fa...@yahoo.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 66347] Add theme support to XWPF
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66347
--- Comment #1 from PJ Fanning <fa...@yahoo.com> ---
thanks - added with r1905344
Would it be possible to add more test coverage - for regression purposes?
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 66347] Add theme support to XWPF
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66347
--- Comment #4 from PJ Fanning <fa...@yahoo.com> ---
thanks - added with r1905374
Would it be possible to add a test where a new themes file is created in a docx
file?
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org