You are viewing a plain text version of this content. The canonical link for it is here.

Posted to submarine-dev@hadoop.apache.org by GitBox <gi...@apache.org> on 2019/10/09 03:03:46 UTC

[GitHub] [hadoop-submarine] jiwq commented on issue #37: [SUBMARINE-174] Create the submarine-server module

jiwq commented on issue #37: [SUBMARINE-174] Create the submarine-server module
URL: https://github.com/apache/hadoop-submarine/pull/37#issuecomment-539801707
 
 
   > 1. I think you need added `submarine-server` design doc in `docs\submarine-server` path.
   > 2. The PR `What is this PR for?` description of this paragraph is too simple. you need to tell others what the PR is going to do.
   > 3. You need to add design doc link in this PR.
   > 4. I think what modules are created by what module you need. Don't create many empty modules at once.
   
   Thanks @liuxunorg help review. I will close this PR and create a new PR for the design doc first.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services