You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/02/24 16:01:00 UTC

[GitHub] [nifi-minifi-cpp] adamdebreceni removed a comment on pull request #1015: MINIFICPP-1509 - Use _stat64 on windows to handle large files

adamdebreceni removed a comment on pull request #1015:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1015#issuecomment-785173989


   Note: eventually we shouldn't include `<sys/stat.h>` but provide a platform-independent abstraction for it, `FileUtils.h` could be that abstraction but since some functions do not unambiguously signal a non-existent file (e.g. `file_size` returns 0 if the stat fails) currently it is not entirely viable to replace the explicit `stat` in `GetFile` or `PutFile` and possible other places


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org