You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/05/15 07:38:29 UTC
[GitHub] [rocketmq] xiaobing395845388 opened a new pull request #1996: Disscuss about hash algorithm in message queue selector ,dev
xiaobing395845388 opened a new pull request #1996:
URL: https://github.com/apache/rocketmq/pull/1996
## What is the purpose of the change
hash algorithm with hashmap of Java 8 is better, algorithm is hashcode ^ (hashcode >>> 16)
## Brief changelog
hash algorithm with hashmap of Java 8 is better, algorithm is hashcode ^ (hashcode >>> 16)
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls edited a comment on pull request #1996: Disscuss about hash algorithm in message queue selector ,dev
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #1996:
URL: https://github.com/apache/rocketmq/pull/1996#issuecomment-629092946
[](https://coveralls.io/builds/30808789)
Coverage increased (+0.03%) to 50.866% when pulling **66420afe9f72455212f1e4869242bc5a09fdf713 on xiaobing395845388:master** into **af0770522dd6daea904b9c766046b175b88a5819 on apache:develop**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] xiaobing395845388 commented on pull request #1996: Disscuss about hash algorithm in message queue selector ,dev
Posted by GitBox <gi...@apache.org>.
xiaobing395845388 commented on pull request #1996:
URL: https://github.com/apache/rocketmq/pull/1996#issuecomment-629090313
Link #1269
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] xiaobing395845388 commented on pull request #1996: Disscuss about hash algorithm in message queue selector ,dev
Posted by GitBox <gi...@apache.org>.
xiaobing395845388 commented on pull request #1996:
URL: https://github.com/apache/rocketmq/pull/1996#issuecomment-629092924
In order to not affect the existing queues, a new class named SelectMessageQueueByUniformHash is added to implement the algorithm
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-io commented on pull request #1996: Disscuss about hash algorithm in message queue selector ,dev
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1996:
URL: https://github.com/apache/rocketmq/pull/1996#issuecomment-629093011
# [Codecov](https://codecov.io/gh/apache/rocketmq/pull/1996?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`develop@40c255d`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/rocketmq/pull/1996?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #1996 +/- ##
==========================================
Coverage ? 45.12%
Complexity ? 4197
==========================================
Files ? 546
Lines ? 35735
Branches ? 4745
==========================================
Hits ? 16126
Misses ? 17566
Partials ? 2043
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/1996?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/1996?src=pr&el=footer). Last update [40c255d...b600f8f](https://codecov.io/gh/apache/rocketmq/pull/1996?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #1996: Disscuss about hash algorithm in message queue selector ,dev
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #1996:
URL: https://github.com/apache/rocketmq/pull/1996#issuecomment-629092946
[](https://coveralls.io/builds/30808359)
Coverage decreased (-0.02%) to 50.816% when pulling **b600f8faac1d182aef020750a4bcacbf42bc05b4 on xiaobing395845388:master** into **af0770522dd6daea904b9c766046b175b88a5819 on apache:develop**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] xiaobing395845388 commented on pull request #1996: Disscuss about hash algorithm in message queue selector ,dev
Posted by GitBox <gi...@apache.org>.
xiaobing395845388 commented on pull request #1996:
URL: https://github.com/apache/rocketmq/pull/1996#issuecomment-629105892
Link #1267
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin closed pull request #1996: Disscuss about hash algorithm in message queue selector ,dev
Posted by GitBox <gi...@apache.org>.
RongtongJin closed pull request #1996:
URL: https://github.com/apache/rocketmq/pull/1996
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin commented on pull request #1996: Disscuss about hash algorithm in message queue selector ,dev
Posted by GitBox <gi...@apache.org>.
RongtongJin commented on pull request #1996:
URL: https://github.com/apache/rocketmq/pull/1996#issuecomment-651751488
I will close this pull request first If you have any questions, you can resubmit the pull request. But Plz pay attention to the following points:
Firstly, plz submit related issues to link this PR and explain the purpose of PR according to the format.
Second, plz name the pull request in the correct format.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org