You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by "Jun Rao (JIRA)" <ji...@apache.org> on 2015/01/16 02:04:01 UTC

[jira] [Commented] (KAFKA-1868) ConsoleConsumer shouldn't override dual.commit.enabled to false if not explicitly set

    [ https://issues.apache.org/jira/browse/KAFKA-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14279626#comment-14279626 ] 

Jun Rao commented on KAFKA-1868:
--------------------------------

Created reviewboard https://reviews.apache.org/r/29953/diff/
 against branch origin/0.8.2

> ConsoleConsumer shouldn't override dual.commit.enabled to false if not explicitly set
> -------------------------------------------------------------------------------------
>
>                 Key: KAFKA-1868
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1868
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.8.2
>            Reporter: Jun Rao
>            Assignee: Jun Rao
>            Priority: Blocker
>             Fix For: 0.8.2
>
>         Attachments: kafka-1868.patch
>
>
> In ConsoleConsumer, we override dual.commit.enabled to false if not explicitly set. However, if offset.storage is set to kafka, by default, dual.commit.enabled is set to true and we shouldn't override that. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)