You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/01/04 12:07:46 UTC

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #37: Improvements for NRF52

acassis commented on a change in pull request #37: Improvements for NRF52
URL: https://github.com/apache/incubator-nuttx/pull/37#discussion_r363031912
 
 

 ##########
 File path: arch/arm/src/nrf52/nrf52_lowputc.c
 ##########
 @@ -216,7 +216,7 @@ void nrf52_usart_configure(uintptr_t base, const struct uart_config_s *config)
  ****************************************************************************/
 
 #ifdef HAVE_UART_DEVICE
-void nrf52_usart_disable(uintptr_t base)
+void nrf52_usart_disable(uintptr_t base, const struct uart_config_s *config)
 
 Review comment:
   Mateuz, I think it is a good idea to add FAR to all these "const struct uart_config_s *", what do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services