You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/09/17 06:03:00 UTC

[GitHub] [hudi] yihua commented on a diff in pull request #6419: [HUDI-2057] CTAS Generate An External Table When Create Managed Table

yihua commented on code in PR #6419:
URL: https://github.com/apache/hudi/pull/6419#discussion_r973545931


##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/ProvidesHoodieConfig.scala:
##########
@@ -174,7 +174,7 @@ trait ProvidesHoodieConfig extends Logging {
 
     val enableHive = isUsingHiveCatalog(sparkSession)
 
-    withSparkConf(sparkSession, catalogProperties) {
+    withSparkConf(sparkSession, catalogProperties ++ extraOptions) {

Review Comment:
   Could you add a test that should fail before this fix, to guard any breaking changes in the future?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org