[jira] [Commented] (LUCENE-5935) bogus TODO inside TestBackwardsCompatibility in trunk

["Michael McCandless (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-5935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14129089#comment-14129089 ] 

Michael McCandless commented on LUCENE-5935:
--------------------------------------------

OK this is what happened:

  * I was adding back compat indices for 4.6.1, but then on porting
    forward from 4.x to trunk (rev 1562506), I noticed that there were
    4.5.0 back compat indices in 4.x's TestBackCompat but they hadn't
    been ported to trunk.

  * So I ported those test indices forward to trunk but they were
    failing to pass TestBackCompat, which was baffling to me at the
    time, so I left them commented out and added that TODO.

  * Shortly later, in rev 1563251, I found the root cause, a bug in
    Lucene45DVProducer, which I fixed, and re-enabled those two, but
    then I failed to remove the TODO.

Net/net we can remove this now-done TODO ... I'll go do that.


> bogus TODO inside TestBackwardsCompatibility in trunk
> -----------------------------------------------------
>
>                 Key: LUCENE-5935
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5935
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>            Priority: Blocker
>
> in TestBackwardsCompatibility in trunk we have:
> {code}
>       // TODO: these are on 4x, but something is wrong (they seem to be a too old DV format):
> {code}
> I put a nocommit above it, to draw as much attention as possible to this. What does this mean, that we aren't testing backwards compatibilty? are tests disabled? I don't see how this is possibly a valid TODO.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org