[jira] [Commented] (MESOS-2126) Libprocess Future: Improve performance, List instead of Queue

["Timothy Chen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-2126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14216876#comment-14216876 ] 

Timothy Chen commented on MESOS-2126:
-------------------------------------

Awesome find!

> Libprocess Future: Improve performance, List instead of Queue
> -------------------------------------------------------------
>
>                 Key: MESOS-2126
>                 URL: https://issues.apache.org/jira/browse/MESOS-2126
>             Project: Mesos
>          Issue Type: Improvement
>          Components: libprocess
>            Reporter: Joris Van Remoortere
>            Assignee: Joris Van Remoortere
>              Labels: future, libprocess, performance
>
> std::queue does dynamic allocation upon construction.
> std::list does dynamic allocation upon insertion.
> Since Future's Data structure currently aggregates 5 queues, this implies a lot of dynamic allocation upon construction of a future. In crucial paths we tend not to use most of these queues, meaning the allocations were of no benefit.
> If we replace std::queue with std::list then we pay per use, which in most cases, and definitely in crucial paths, reduces dynamic allocation and improves performance.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)