[jira] Commented: (HARMONY-686) [classlib][nio] Refactor SocketAdapter.checkClosedAndCreate(boolean) in o.a.h.nio.internal.SocketChannelImpl

["Andrew Zhang (JIRA)" <ji...@apache.org>]

    [ http://issues.apache.org/jira/browse/HARMONY-686?page=comments#action_12418357 ] 

Andrew Zhang commented on HARMONY-686:
--------------------------------------

Hello George,

The fix looks good, thanks!

Best regards,
Andrew

> [classlib][nio] Refactor SocketAdapter.checkClosedAndCreate(boolean) in o.a.h.nio.internal.SocketChannelImpl
> ------------------------------------------------------------------------------------------------------------
>
>          Key: HARMONY-686
>          URL: http://issues.apache.org/jira/browse/HARMONY-686
>      Project: Harmony
>         Type: Improvement

>   Components: Classlib
>     Reporter: Andrew Zhang
>     Assignee: George Harley
>     Priority: Minor
>  Attachments: nio.diff
>
> There are several problems in SocketAdapter.checkClosedAndCreate(boolean) method:
> 1. Unused parameter. The boolean parameter is unnecessary.
> 2. Improper method name. This method only checks whether the channel is open, and has nothing to do with "create".
> 3. One FIXME. 
> I'll upload a patch soon. Thanks!
> Best regards,
> Andrew

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira