[jira] [Updated] (AMBARI-10466) RU TODO : Get rid of the UPGRADE_FORCE_DOWNGRADE property

["Dmitry Lysnichenko (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/AMBARI-10466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dmitry Lysnichenko updated AMBARI-10466:
----------------------------------------
    Attachment: AMBARI-10466.patch

> RU TODO : Get rid of the UPGRADE_FORCE_DOWNGRADE property
> ---------------------------------------------------------
>
>                 Key: AMBARI-10466
>                 URL: https://issues.apache.org/jira/browse/AMBARI-10466
>             Project: Ambari
>          Issue Type: Improvement
>          Components: ambari-server
>            Reporter: Dmitry Lysnichenko
>            Assignee: Dmitry Lysnichenko
>             Fix For: 2.1.0
>
>         Attachments: AMBARI-10466.patch
>
>
> org.apache.ambari.server.controller.internal.UpgradeResourceProvider
> {code}
>   // TODO : Get rid of the UPGRADE_FORCE_DOWNGRADE property... should use downgrade create directive
>   protected static final String UPGRADE_FORCE_DOWNGRADE = "Upgrade/force_downgrade";
> {code}
> initailly there was an UPGRADE_FORCE_DOWNGRADE property for the upgrade resource. This property would be set to true and passed in the body of a POST to create an upgrade to indicate that the upgrade was really a downgrade. It was suggested that instead of having a property on the resource that it would be better to use a create directive of 'downgrade' in the POST when the resource was first created. When I added the directive, I didn't immediately remove the property since it would have broken the existing users (Ambari UI) of the API. Instead I added the TODO.
> Right now the code looks for the directive first and then checks for the property. As long as nobody is still creating the upgrade resource with the UPGRADE_FORCE_DOWNGRADE property, it should be safe to just remove it and the little bit of related code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)