[jira] [Commented] (NIFI-3510) log when ControllerService is ENABLED

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-3510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16163608#comment-16163608 ] 

ASF GitHub Bot commented on NIFI-3510:
--------------------------------------

GitHub user m-hogue opened a pull request:

    https://github.com/apache/nifi/pull/2151

    NIFI-3510: Added logging for when controller services are enabled/dis…

    …abled
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/m-hogue/nifi NIFI-3510

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2151.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2151
    
----
commit fba12241f2a2622ff2aab8a61129c198ba815068
Author: m-hogue <ho...@gmail.com>
Date:   2017-09-12T20:30:02Z

    NIFI-3510: Added logging for when controller services are enabled/disabled

----


> log when ControllerService is ENABLED
> -------------------------------------
>
>                 Key: NIFI-3510
>                 URL: https://issues.apache.org/jira/browse/NIFI-3510
>             Project: Apache NiFi
>          Issue Type: Improvement
>    Affects Versions: 0.7.1, 1.1.1
>            Reporter: Brandon DeVries
>            Assignee: Michael Hogue
>            Priority: Trivial
>
> We currently have logging for when we begin "enabling" a controller service, but none for when it has actually been "enabled".  I suggest adding a line like 
> {code}
> LOG.debug("Successfully Enabled " + this);
> {code}
> to StandardControllerServiceNode.enable()...
> 0.x:
> {code}
> if (shouldEnable) {
>     heartbeater.heartbeat();
>     LOG.debug("Successfully Enabled " + this);
> } else {...
> {code}
> https://github.com/apache/nifi/blob/0.x/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/service/StandardControllerServiceNode.java#L313-L315
> 1.x:
> {code}
> ...
> }
> else{
>     LOG.debug("Successfully Enabled " + this);
> }
> {code}
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/service/StandardControllerServiceNode.java#L357
> [~mosermw] [~jskora]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)