You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/10/09 16:00:18 UTC
[GitHub] [airflow] potiuk opened a new pull request #18852: Decrease likelihood of memory issue in CI
potiuk opened a new pull request #18852:
URL: https://github.com/apache/airflow/pull/18852
This PR attempts to decrease the likelihood of memory issues for
CI for non-committers. The MSSQL and MYSQL Provider and Integration
tests when run together with other tests in parallel (for MSSQL even
standalone) might cause memory problems (143 or 137 exit code).
This PR changes the approach slightly for low-memory conditions:
1) MSSQL - both Integration and Providers tests are skipped
entirely (they will be run in High-Mem case so we will see if
there are any problems anyway)
2) MySQL - both Integration and Providers tests are run separately
which will lead to slightly longer test runs but likely this
will save us from the occasional memory issues.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] malthe commented on a change in pull request #18852: Decrease likelihood of memory issue in CI
Posted by GitBox <gi...@apache.org>.
malthe commented on a change in pull request #18852:
URL: https://github.com/apache/airflow/pull/18852#discussion_r726074697
##########
File path: scripts/ci/testing/ci_run_airflow_testing.sh
##########
@@ -92,14 +93,28 @@ function run_all_test_types_in_parallel() {
echo ""
echo "${COLOR_YELLOW}Integration tests will be run separately at the end after cleaning up docker${COLOR_RESET}"
echo ""
- # Remove Integration from list of tests to run in parallel
- test_types_to_run="${test_types_to_run//Integration/}"
- run_integration_tests_separately="true"
if [[ ${BACKEND} == "mssql" ]]; then
- # Skip running "Integration" tests for low memory condition for mssql
- run_integration_tests_separately="false"
+ # Skip running "Integration" and "Providers" tests for low memory condition for mssql
+ # Both might lead to memory issues even in run on their own. We have no need to
+ # Test those specifically for MSSQL (and they will be tested in `main` as there
+ # We have no memory limits
+ test_types_to_run="${test_types_to_run//Integration/}"
+ run_integration_tests_separately="false"
+ test_types_to_run="${test_types_to_run//Providers/}"
Review comment:
Merge error?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #18852: Decrease likelihood of memory issue in CI
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18852:
URL: https://github.com/apache/airflow/pull/18852#issuecomment-941211636
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #18852: Decrease likelihood of memory issue in CI
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #18852:
URL: https://github.com/apache/airflow/pull/18852#issuecomment-939368715
Except few other problems (that led to few other "flaky fix" PRs) this one worked fine on my test run in my fork: https://github.com/potiuk/airflow/actions/runs/1323849397
Runing Providers and Integration separately for MySQL here: https://github.com/potiuk/airflow/runs/3847290190?check_suite_focus=true
Skipping Providers and Integration for MsSQL here: https://github.com/potiuk/airflow/runs/3847290224?check_suite_focus=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #18852: Decrease likelihood of memory issue in CI
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #18852:
URL: https://github.com/apache/airflow/pull/18852#issuecomment-939368715
Except few other problems (that led to few other "flaky fix" PRs) this one worked fine on my test run in my fork: https://github.com/potiuk/airflow/actions/runs/1323849397
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #18852: Decrease likelihood of memory issue in CI
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #18852:
URL: https://github.com/apache/airflow/pull/18852#issuecomment-940943526
This one also happens intermittently - and I think it would be great to merge that one to get more stable CI runs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #18852: Decrease likelihood of memory issue in CI
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #18852:
URL: https://github.com/apache/airflow/pull/18852#issuecomment-939368715
Except few other problems (that led to few other "flaky fix" PRs) this one worked fine on my test run in my fork: https://github.com/potiuk/airflow/actions/runs/1323849397
* Runing Providers and Integration separately for MySQL here: https://github.com/potiuk/airflow/runs/3847290190?check_suite_focus=true
* Skipping Providers and Integration for MsSQL here: https://github.com/potiuk/airflow/runs/3847290224?check_suite_focus=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #18852: Decrease likelihood of memory issue in CI
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #18852:
URL: https://github.com/apache/airflow/pull/18852
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #18852: Decrease likelihood of memory issue in CI
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #18852:
URL: https://github.com/apache/airflow/pull/18852
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #18852: Decrease likelihood of memory issue in CI
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18852:
URL: https://github.com/apache/airflow/pull/18852#issuecomment-941211636
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org