[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #4140: [TE] Update TE-Raptor API to support multiple metrics

[GitBox <gi...@apache.org>]

jihaozh commented on a change in pull request #4140: [TE] Update TE-Raptor API to support multiple metrics
URL: https://github.com/apache/incubator-pinot/pull/4140#discussion_r276875329
 
 

 ##########
 File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/api/user/dashboard/UserDashboardResource.java
 ##########
 @@ -139,57 +187,25 @@ public UserDashboardResource(MergedAnomalyResultManager anomalyDAO, MetricConfig
       @QueryParam("metric") String metric,
       @ApiParam(value = "The name of the pinot table to which this metric belongs")
       @QueryParam("dataset") String dataset,
+      @ApiParam(value = "Comma separated list of dataset.metric E.g., D1::M1,D1::M2,D2::M3")
+      @QueryParam("metricDatasetPairs") String metricDatasetPairs,
 
 Review comment:
   For example, here the function signature looks like`@QueryParam("metricDatasetPair") List<MetricDatasetPair> metricDatasetPairs`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org