You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@omid.apache.org by ohadshacham <gi...@git.apache.org> on 2018/03/12 13:07:09 UTC

[GitHub] incubator-omid pull request #24: [OMID-92] Add Apache Rat to the build proce...

GitHub user ohadshacham opened a pull request:

    https://github.com/apache/incubator-omid/pull/24

    [OMID-92] Add Apache Rat to the build process and align code with Rat…

    …'s requirement.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ohadshacham/incubator-omid OMID-92

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-omid/pull/24.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #24
    
----
commit aea8b149366264da01a883c616b34675dc74d4bf
Author: Ohad Shacham <oh...@...>
Date:   2018-03-12T13:04:27Z

    [OMID-92] Add Apache Rat to the build process and align code with Rat's requirement.

----


---

[GitHub] incubator-omid pull request #24: [OMID-92] Add Apache Rat to the build proce...

Posted by ohadshacham <gi...@git.apache.org>.

Github user ohadshacham closed the pull request at:

    https://github.com/apache/incubator-omid/pull/24


---

[GitHub] incubator-omid issue #24: [OMID-92] Add Apache Rat to the build process and ...

Posted by JamesRTaylor <gi...@git.apache.org>.

Github user JamesRTaylor commented on the issue:

    https://github.com/apache/incubator-omid/pull/24
  
    Changes look good. Couple of minor nits:
    * Instead of excluding .md, why not just add the ASF header?
    * Do you want to have rat automatically run by mvn when you get ready to do a release?


---