You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2022/07/20 00:38:30 UTC
[GitHub] [drill] pjfanning opened a new pull request, #2609: DRILL-8267: try to remove commons-configuration jar
pjfanning opened a new pull request, #2609:
URL: https://github.com/apache/drill/pull/2609
## Description
(Please describe the change. If more than one ticket is fixed, include a reference to those tickets.)
## Documentation
(Please describe user-visible changes similar to what should appear in the Drill documentation.)
## Testing
(Please describe how this PR has been tested.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] jnturton closed pull request #2609: DRILL-8267: Remove commons-configuration dependency management
Posted by GitBox <gi...@apache.org>.
jnturton closed pull request #2609: DRILL-8267: Remove commons-configuration dependency management
URL: https://github.com/apache/drill/pull/2609
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] pjfanning commented on pull request #2609: DRILL-8267: try to remove commons-configuration jar
Posted by GitBox <gi...@apache.org>.
pjfanning commented on PR #2609:
URL: https://github.com/apache/drill/pull/2609#issuecomment-1189772826
I suspect that maybe hadoop (or some other lib) used to use commons-configuration instead of commons-configuration2 as it does now - and that Drill added the dependency to try to keep the maven build happy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] jnturton commented on a diff in pull request #2609: DRILL-8267: Remove commons-configuration dependency management
Posted by GitBox <gi...@apache.org>.
jnturton commented on code in PR #2609:
URL: https://github.com/apache/drill/pull/2609#discussion_r925256805
##########
pom.xml:
##########
@@ -1984,17 +1983,6 @@
<artifactId>xercesImpl</artifactId>
<version>${xerces.version}</version>
</dependency>
- <dependency>
Review Comment:
Note that what we're doing here is removing the _management_ of a dependency from the dependencyManagement element, not removing any dependency itself. If I look at a Drill installation then I see that we don't ship commons-configuration, only commons-configuration2.
```
➜ ~ ls /opt/apache-drill-1.20.1/jars/3rdparty/commons-conf*
/opt/apache-drill-1.20.1/jars/3rdparty/commons-configuration2-2.1.1.jar
```
If I then look at `mvn dependency:tree` I see that the Phoenix storage plugin is the one place where we depend on commons-configration via org.apache.phoenix:phoenix-core
```
[INFO] org.apache.drill.contrib:drill-storage-phoenix:jar:2.0.0-SNAPSHOT
[INFO] \- org.apache.phoenix:phoenix-core:jar:tests:5.1.2:test
[INFO] \- org.apache.omid:omid-transaction-client:jar:1.0.2:test
[INFO] \- commons-configuration:commons-configuration:jar:1.10:test
```
but the scope of dependency is _test_ which explains why commons-configuration is not to be found in a Drill installation.
Bottom line: I don't think we do need to manage this dependency any more so I'm in favour of this change even though it has no impact, because it simplifies our beast of a pom. But the Jira and the PR descriptions should be adjusted to reflect what's happening: "Remove unneeded management of commons-configuration which only appears in test scope for storage-phoenix" or something.
Let's also check in with @vdiravka about this change...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] jnturton commented on a diff in pull request #2609: DRILL-8267: Remove commons-configuration dependency management
Posted by GitBox <gi...@apache.org>.
jnturton commented on code in PR #2609:
URL: https://github.com/apache/drill/pull/2609#discussion_r926359954
##########
pom.xml:
##########
@@ -1984,17 +1983,6 @@
<artifactId>xercesImpl</artifactId>
<version>${xerces.version}</version>
</dependency>
- <dependency>
Review Comment:
Okay @pjfanning, based on @vdiravka's comments I think this dependency management is helping (to keep commons-logging out) and not hurting, so we should probably just leave it as it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] jnturton commented on pull request #2609: DRILL-8267: Remove commons-configuration dependency management
Posted by GitBox <gi...@apache.org>.
jnturton commented on PR #2609:
URL: https://github.com/apache/drill/pull/2609#issuecomment-1192225931
@pjfanning are you happy to close this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] vdiravka commented on a diff in pull request #2609: DRILL-8267: Remove commons-configuration dependency management
Posted by GitBox <gi...@apache.org>.
vdiravka commented on code in PR #2609:
URL: https://github.com/apache/drill/pull/2609#discussion_r926320649
##########
pom.xml:
##########
@@ -1984,17 +1983,6 @@
<artifactId>xercesImpl</artifactId>
<version>${xerces.version}</version>
</dependency>
- <dependency>
Review Comment:
This management is for two purposes:
1. Per commit DRILL-7713 I understand the dependency was added to remove vulnerability from the transitive dependencies.
2. To avoid using `commons-logging` as dependency. https://github.com/apache/commons-configuration/blob/master/pom.xml#L301
In case we are sure `commons-configuration` dependency is [1.10](https://github.com/apache/phoenix-omid/blob/ba43c8e1d73543fafa102c57af79516c4dc88860/pom.xml#L175) or newer version in Drill after removing this management and `commons-logging` is not used (successful mvn build is enough for this, because [commons-logging](https://github.com/apache/drill/blob/master/pom.xml#L663) is banned in Drill), we can remove this management.
The other question do we really need it?! It is possible in future the new dependency will have `commons-configuration` as a transitive dependency and we will face with the same issues, but now they are solved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org