You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2022/07/01 04:02:52 UTC

[kudu-CR] [java] KUDU-2671 require RANGE SPECIFIC HASH SCHEMA when necessary

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18687


Change subject: [java] KUDU-2671 require RANGE_SPECIFIC_HASH_SCHEMA when necessary
......................................................................

[java] KUDU-2671 require RANGE_SPECIFIC_HASH_SCHEMA when necessary

With this patch, Kudu Java client requires the newly introduced feature
flag RANGE_SPECIFIC_HASH_SCHEMA to be present at the server side when
creating a table with range-specific hash schemas.  The flag is also
required when altering already existing table, adding a new range
partition with custom hash schema.

This patch also provides test coverage for the newly introduced
functionality.

This is a follow-up to https://gerrit.cloudera.org/#/c/18633

Change-Id: I7e6625277cc2fb63000999f0c74d9b3d929d5657
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableRequest.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
6 files changed, 121 insertions(+), 10 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/87/18687/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18687
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7e6625277cc2fb63000999f0c74d9b3d929d5657
Gerrit-Change-Number: 18687
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR] [java] KUDU-2671 require RANGE SPECIFIC HASH SCHEMA when necessary

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: [java] KUDU-2671 require RANGE_SPECIFIC_HASH_SCHEMA when necessary
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/18687
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I7e6625277cc2fb63000999f0c74d9b3d929d5657
Gerrit-Change-Number: 18687
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>

[kudu-CR] [java] KUDU-2671 require RANGE SPECIFIC HASH SCHEMA when necessary

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/18687 )

Change subject: [java] KUDU-2671 require RANGE_SPECIFIC_HASH_SCHEMA when necessary
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18687
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e6625277cc2fb63000999f0c74d9b3d929d5657
Gerrit-Change-Number: 18687
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 Jul 2022 15:47:26 +0000
Gerrit-HasComments: No

[kudu-CR] [java] KUDU-2671 require RANGE SPECIFIC HASH SCHEMA when necessary

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18687 )

Change subject: [java] KUDU-2671 require RANGE_SPECIFIC_HASH_SCHEMA when necessary
......................................................................


Patch Set 2: Verified+1

unrelated test failure: log-rolling-itest (ASAN)


-- 
To view, visit http://gerrit.cloudera.org:8080/18687
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e6625277cc2fb63000999f0c74d9b3d929d5657
Gerrit-Change-Number: 18687
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Sat, 02 Jul 2022 00:40:15 +0000
Gerrit-HasComments: No

[kudu-CR] [java] KUDU-2671 require RANGE SPECIFIC HASH SCHEMA when necessary

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18687 )

Change subject: [java] KUDU-2671 require RANGE_SPECIFIC_HASH_SCHEMA when necessary
......................................................................


Patch Set 1: Verified+1

unrelated test failure: log-rolling-itest


-- 
To view, visit http://gerrit.cloudera.org:8080/18687
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e6625277cc2fb63000999f0c74d9b3d929d5657
Gerrit-Change-Number: 18687
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 Jul 2022 04:51:21 +0000
Gerrit-HasComments: No

[kudu-CR] [java] KUDU-2671 require RANGE SPECIFIC HASH SCHEMA when necessary

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: [java] KUDU-2671 require RANGE_SPECIFIC_HASH_SCHEMA when necessary
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/18687
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I7e6625277cc2fb63000999f0c74d9b3d929d5657
Gerrit-Change-Number: 18687
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>

[kudu-CR] [java] KUDU-2671 require RANGE SPECIFIC HASH SCHEMA when necessary

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18687 )

Change subject: [java] KUDU-2671 require RANGE_SPECIFIC_HASH_SCHEMA when necessary
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18687
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e6625277cc2fb63000999f0c74d9b3d929d5657
Gerrit-Change-Number: 18687
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 Jul 2022 23:05:23 +0000
Gerrit-HasComments: No

[kudu-CR] [java] KUDU-2671 require RANGE SPECIFIC HASH SCHEMA when necessary

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18687 )

Change subject: [java] KUDU-2671 require RANGE_SPECIFIC_HASH_SCHEMA when necessary
......................................................................

[java] KUDU-2671 require RANGE_SPECIFIC_HASH_SCHEMA when necessary

With this patch, Kudu Java client requires the newly introduced feature
flag RANGE_SPECIFIC_HASH_SCHEMA to be present at the server side when
creating a table with range-specific hash schemas.  The flag is also
required when altering already existing table, adding a new range
partition with custom hash schema.

This patch also provides test coverage for the newly introduced
functionality.

This is a follow-up to https://gerrit.cloudera.org/#/c/18633

Change-Id: I7e6625277cc2fb63000999f0c74d9b3d929d5657
Reviewed-on: http://gerrit.cloudera.org:8080/18687
Reviewed-by: Attila Bukor <ab...@apache.org>
Tested-by: Alexey Serbin <al...@apache.org>
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableRequest.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
6 files changed, 121 insertions(+), 10 deletions(-)

Approvals:
  Attila Bukor: Looks good to me, approved
  Alexey Serbin: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/18687
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7e6625277cc2fb63000999f0c74d9b3d929d5657
Gerrit-Change-Number: 18687
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>

[kudu-CR] [java] KUDU-2671 require RANGE SPECIFIC HASH SCHEMA when necessary

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18687 )

Change subject: [java] KUDU-2671 require RANGE_SPECIFIC_HASH_SCHEMA when necessary
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18687
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e6625277cc2fb63000999f0c74d9b3d929d5657
Gerrit-Change-Number: 18687
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 Jul 2022 22:57:49 +0000
Gerrit-HasComments: No

[kudu-CR] [java] KUDU-2671 require RANGE SPECIFIC HASH SCHEMA when necessary

Posted by "Mahesh Reddy (Code Review)" <ge...@cloudera.org>.
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18687 )

Change subject: [java] KUDU-2671 require RANGE_SPECIFIC_HASH_SCHEMA when necessary
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18687
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e6625277cc2fb63000999f0c74d9b3d929d5657
Gerrit-Change-Number: 18687
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 Jul 2022 09:53:53 +0000
Gerrit-HasComments: No