You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "wilfred-s (via GitHub)" <gi...@apache.org> on 2023/06/16 05:59:58 UTC

[GitHub] [yunikorn-release] wilfred-s opened a new pull request, #148: [YUNIKORN-1810] Use arm64 without variant for DOCKER_ARCH

wilfred-s opened a new pull request, #148:
URL: https://github.com/apache/yunikorn-release/pull/148

   ### What is this PR for?
   Building multi architecture image fails to properly split the variant from the main architecture and binary does not change without variant.
   
   ### What type of PR is it?
   * [X] - Bug Fix
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/YUNIKORN-1810
   
   ### How should this be tested?
   Local and release build should generate single and multi architecture images that work on arm


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [yunikorn-release] wilfred-s closed pull request #148: [YUNIKORN-1810] Use arm64 without variant for DOCKER_ARCH

Posted by "wilfred-s (via GitHub)" <gi...@apache.org>.
wilfred-s closed pull request #148: [YUNIKORN-1810] Use arm64 without variant for DOCKER_ARCH
URL: https://github.com/apache/yunikorn-release/pull/148


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [yunikorn-release] zhuqi-lucas commented on a diff in pull request #148: [YUNIKORN-1810] Use arm64 without variant for DOCKER_ARCH

Posted by "zhuqi-lucas (via GitHub)" <gi...@apache.org>.
zhuqi-lucas commented on code in PR #148:
URL: https://github.com/apache/yunikorn-release/pull/148#discussion_r1232015021


##########
tools/build-image.py:
##########
@@ -172,6 +172,8 @@ def build_manifest(manifest, version):
     for arch in architecture:
         image_name = create_image_name(manifest, version, architecture[arch])
         print(" - image:    %s" % image_name)
+        # image_manifest = create_image_name(manifest, version, manifestmap[arch])

Review Comment:
   If we want to remain this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org