You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by ma...@apache.org on 2019/10/06 18:29:36 UTC
[logging-log4j2] 01/04: Update TODO comments
This is an automated email from the ASF dual-hosted git repository.
mattsicker pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/logging-log4j2.git
commit 4c64c261fe8f2e0c33a57c3f758547797c48a49b
Author: Matt Sicker <bo...@gmail.com>
AuthorDate: Sun Sep 15 11:31:24 2019 -0500
Update TODO comments
Signed-off-by: Matt Sicker <bo...@gmail.com>
---
.../java/org/apache/logging/log4j/plugins/PluginBuilderAttribute.java | 2 +-
.../src/main/java/org/apache/logging/log4j/plugins/PluginElement.java | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/log4j-plugins/src/main/java/org/apache/logging/log4j/plugins/PluginBuilderAttribute.java b/log4j-plugins/src/main/java/org/apache/logging/log4j/plugins/PluginBuilderAttribute.java
index 36e6ff2..3f3d597 100644
--- a/log4j-plugins/src/main/java/org/apache/logging/log4j/plugins/PluginBuilderAttribute.java
+++ b/log4j-plugins/src/main/java/org/apache/logging/log4j/plugins/PluginBuilderAttribute.java
@@ -34,7 +34,7 @@ import java.lang.annotation.Target;
@Retention(RetentionPolicy.RUNTIME)
@Target({ElementType.PARAMETER, ElementType.FIELD, ElementType.TYPE})
@InjectionStrategy(PluginBuilderAttributeBuilder.class)
-// TODO: this annotation can be combined with @PluginAttribute along with giving it a default value
+// TODO: this annotation can be combined with @PluginAttribute
public @interface PluginBuilderAttribute {
/**
diff --git a/log4j-plugins/src/main/java/org/apache/logging/log4j/plugins/PluginElement.java b/log4j-plugins/src/main/java/org/apache/logging/log4j/plugins/PluginElement.java
index 919d138..deb4641 100644
--- a/log4j-plugins/src/main/java/org/apache/logging/log4j/plugins/PluginElement.java
+++ b/log4j-plugins/src/main/java/org/apache/logging/log4j/plugins/PluginElement.java
@@ -32,6 +32,7 @@ import java.lang.annotation.Target;
@Retention(RetentionPolicy.RUNTIME)
@Target({ElementType.PARAMETER, ElementType.FIELD})
@InjectionStrategy(PluginElementBuilder.class)
+// TODO: this can have a default value to use reflection
public @interface PluginElement {
/**