You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/05/25 02:14:39 UTC
[GitHub] [rocketmq-client-cpp] ifplusor opened a new pull request #313: Fixed TpsReportService::start
ifplusor opened a new pull request #313:
URL: https://github.com/apache/rocketmq-client-cpp/pull/313
## What is the purpose of the change
Fixed TpsReportService::start().
## Brief changelog
Create thread if tps_thread_ is nullptr.
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-cpp] phaniranjan commented on pull request #313: Fixed TpsReportService::start
Posted by GitBox <gi...@apache.org>.
phaniranjan commented on pull request #313:
URL: https://github.com/apache/rocketmq-client-cpp/pull/313#issuecomment-633700870
@ifplusor Hello James, Issue occurs when the thread count is more than 1 and AsycPushConsumer gives segmentation fault. But i was able to verify with single thread producer & Pull consumer. Message exchanges happen
[root@localhost example]# !237
./PullConsumer -n "localhost:9876" -g "TestGroup" -t "MyTopicMessage" -T "1"
nameserver: localhost:9876
topic: MyTopicMessage
groupname: TestGroup
produce content: msgbody for test
msg count: 1
thread count: 1
mq:MessageQueue [topic=MyTopicMessage, brokerName=localhost.localdomain, queueId=0]
mq:MessageQueue [topic=MyTopicMessage, brokerName=localhost.localdomain, queueId=1]
mq:MessageQueue [topic=MyTopicMessage, brokerName=localhost.localdomain, queueId=2]
mq:MessageQueue [topic=MyTopicMessage, brokerName=localhost.localdomain, queueId=3]
32
PullResult [ pullStatus=FOUND, nextBeginOffset=32, minOffset=0, maxOffset=473, msgFoundList=32 ]
PullResult [ pullStatus=FOUND, nextBeginOffset=32, minOffset=0, maxOffset=473, msgFoundList=32 ]
=======================================================
MessageExt [queueId=0, storeSize=180, queueOffset=0, sysFlag=0, bornTimestamp=1590176905475, bornHost=10.22.7.89, storeTimestamp=1590176905519, storeHost=10.22.7.89, msgId=7F00000121D6439F85AE706595030000, commitLogOffset=899630, bodyCRC=1797452670, reconsumeTimes=0, preparedTransactionOffset=0, Message [topic=MyTopicMessage, flag=0, tag=*]]
=======================================================.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-cpp] ifplusor commented on pull request #313: Fixed TpsReportService::start
Posted by GitBox <gi...@apache.org>.
ifplusor commented on pull request #313:
URL: https://github.com/apache/rocketmq-client-cpp/pull/313#issuecomment-633454154
@phaniranjan I have no idea for this, could you post stacktrack?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-cpp] phaniranjan edited a comment on pull request #313: Fixed TpsReportService::start
Posted by GitBox <gi...@apache.org>.
phaniranjan edited a comment on pull request #313:
URL: https://github.com/apache/rocketmq-client-cpp/pull/313#issuecomment-633385199
Thank you James, (@ifplusor ) for the quick fix. This issue was causing all producer/consumer examples to fail at the same location. I will try to execute the current fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-cpp] phaniranjan commented on pull request #313: Fixed TpsReportService::start
Posted by GitBox <gi...@apache.org>.
phaniranjan commented on pull request #313:
URL: https://github.com/apache/rocketmq-client-cpp/pull/313#issuecomment-633390466
I have rebuilt the sources with this fix & tried to execute, the thread starts without issue but there is another exception message shown in the logs & consumer will lead to a segmentation fault. Let me know if the usage parameters are not missing or require additional input values.
[vectone@localhost example]$ !714
./AsyncProducer -n "localhost:9876" -g "TestGroup" -t "MyTopicMessage"
nameserver: localhost:9876
topic: MyTopicMessage
groupname: TestGroup
produce content: msgbody for test
msg count: 1
thread count: 8
send Exception
send Exception
send Exception
send Exception
send Exception
send Exception
send Exception
send Exception
send Exception
per msg time: 6ms
========================finished==============================
tps: 26
[vectone@localhost example]$ !715
./AsyncPushConsumer -n "localhost:9876" -g "TestGroup" -t "MyTopicMessage"
nameserver: localhost:9876
topic: MyTopicMessage
groupname: TestGroup
produce content: msgbody for test
msg count: 1
thread count: 8
Segmentation fault (core dumped)
[vectone@localhost example]$
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-cpp] phaniranjan commented on pull request #313: Fixed TpsReportService::start
Posted by GitBox <gi...@apache.org>.
phaniranjan commented on pull request #313:
URL: https://github.com/apache/rocketmq-client-cpp/pull/313#issuecomment-633385199
Thank you Shannon for the quick fix. This issue was causing all producer/consumer examples to fail at the same location. I will try to execute the current fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-cpp] phaniranjan edited a comment on pull request #313: Fixed TpsReportService::start
Posted by GitBox <gi...@apache.org>.
phaniranjan edited a comment on pull request #313:
URL: https://github.com/apache/rocketmq-client-cpp/pull/313#issuecomment-633700870
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-cpp] ifplusor merged pull request #313: Fixed TpsReportService::start
Posted by GitBox <gi...@apache.org>.
ifplusor merged pull request #313:
URL: https://github.com/apache/rocketmq-client-cpp/pull/313
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-cpp] codecov-commenter commented on pull request #313: Fixed TpsReportService::start
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #313:
URL: https://github.com/apache/rocketmq-client-cpp/pull/313#issuecomment-633346717
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/313?src=pr&el=h1) Report
> Merging [#313](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/313?src=pr&el=desc) into [master](https://codecov.io/gh/apache/rocketmq-client-cpp/commit/6f5261595a1245d2a890a674a062d3b398f0c541&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/313?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #313 +/- ##
=======================================
Coverage 59.01% 59.01%
=======================================
Files 205 205
Lines 12985 12985
=======================================
Hits 7663 7663
Misses 5322 5322
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/313?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/313?src=pr&el=footer). Last update [6f52615...5ae6f84](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/313?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org