You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2019/12/06 17:22:12 UTC

[GitHub] [camel-quarkus] lburgazzoli opened a new pull request #524: refactor FHIR integration tests

lburgazzoli opened a new pull request #524: refactor FHIR integration tests
URL: https://github.com/apache/camel-quarkus/pull/524
 
 
   While experimenting a little bit about other topics (https://github.com/apache/camel-quarkus/issues/457, https://github.com/apache/camel-quarkus/issues/516), I've used the FHIR extension as target for my experiments.
   
   I've started about providing some junit5 extensions so that tests can be easily excluded using the same `flags` we use at build time to enable/disable some build steps, like:
   
   ```java
       @Test
       @EnabledIf(FhirFlags.Dstu2Enabled.class)
       public void jsonDstu2() {
           ....
       }
   ```
   
   The second thing is that I did work a little bit to enhance the [api-fhir-jpaserver-starter](https://github.com/hapifhir/hapi-fhir-jpaserver-starter) by adding an option to override properties from environment variables https://github.com/hapifhir/hapi-fhir-jpaserver-starter/pull/67 and to create a [docker image](https://quay.io/repository/lburgazzoli/hapi-fhir-jpaserver-starter?tab=tags) we can use to simplify the test set-up of the quarkus extension by leverage `tescontainers` (the same image can be used also to the the camel component in the future).
   
   The downside of this experiment is that the image used for tests is hosted in my own repository but I've raised an [issue](https://github.com/hapifhir/hapi-fhir-jpaserver-starter/issues/68) to publish images every time a new release of the hapi happen.
   
   @johnpoth what do you think ? does it make sense to merge it on master ?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services