You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by shivaram <gi...@git.apache.org> on 2017/02/01 06:18:56 UTC

[GitHub] spark pull request #16720: [SPARK-19387][SPARKR] Tests do not run with Spark...

Github user shivaram commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16720#discussion_r98833957
  
    --- Diff: R/pkg/inst/tests/testthat/test_utils.R ---
    @@ -17,6 +17,9 @@
     
     context("functions in utils.R")
     
    +# Ensure Spark is installed
    +sparkCheckInstall()
    --- End diff --
    
    What I had in mind was to combine the `sparkR.session` and this `sparkCheckInstall` into one function so its easy to remember for a new test file. Any thoughts on this ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org