You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by Rakesh R <ra...@huawei.com> on 2015/03/02 18:26:10 UTC

Re: Review Request 20071: ZOOKEEPER-1907]-mprove the thread handling by detecting if any of the critical thread dies.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20071/
-----------------------------------------------------------

(Updated March 2, 2015, 5:26 p.m.)


Review request for zookeeper, michim, Raul Gutierrez Segales, and Camille Fournier.


Bugs: ZOOKEEPER-1907
    https://issues.apache.org/jira/browse/ZOOKEEPER-1907


Repository: zookeeper


Description
-------

Improve the thread handling mechanism by detecting if any of the critical thread dies.
Here the idea is to periodically checking the status of all the critical threads in ZK server using DeathWatcherThread.


Diffs (updated)
-----

  ./src/java/main/org/apache/zookeeper/server/ExitCode.java PRE-CREATION 
  ./src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 1661461 
  ./src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java 1661461 
  ./src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java 1661461 
  ./src/java/main/org/apache/zookeeper/server/ZooKeeperCriticalThread.java 1661461 
  ./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 1661461 
  ./src/java/main/org/apache/zookeeper/server/ZooKeeperServerListener.java PRE-CREATION 
  ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java 1661461 
  ./src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java 1661461 
  ./src/java/main/org/apache/zookeeper/server/quorum/FollowerZooKeeperServer.java 1661461 
  ./src/java/main/org/apache/zookeeper/server/quorum/LeaderSessionTracker.java 1661461 
  ./src/java/main/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java 1661461 
  ./src/java/main/org/apache/zookeeper/server/quorum/LearnerSessionTracker.java 1661461 
  ./src/java/main/org/apache/zookeeper/server/quorum/LearnerZooKeeperServer.java 1661461 
  ./src/java/main/org/apache/zookeeper/server/quorum/LocalSessionTracker.java 1661461 
  ./src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java 1661461 
  ./src/java/main/org/apache/zookeeper/server/quorum/ObserverZooKeeperServer.java 1661461 
  ./src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java 1661461 
  ./src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyZooKeeperServer.java 1661461 
  ./src/java/main/org/apache/zookeeper/server/quorum/UpgradeableSessionTracker.java 1661461 
  ./src/java/test/org/apache/zookeeper/server/ZooKeeperThreadTest.java 1661461 
  ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorConcurrencyTest.java 1661461 
  ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java 1661461 
  ./src/java/test/org/apache/zookeeper/test/ClientBase.java 1661461 
  ./src/java/test/org/apache/zookeeper/test/SessionTrackerCheckTest.java 1661461 

Diff: https://reviews.apache.org/r/20071/diff/


Testing
-------

yet to be inlcuded


Thanks,

Rakesh R


Re: Review Request 20071: ZOOKEEPER-1907]-mprove the thread handling by detecting if any of the critical thread dies.

Posted by Rakesh R <ra...@huawei.com>.

> On March 2, 2015, 5:35 p.m., Hongchao Deng wrote:
> > ./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java, line 688
> > <https://reviews.apache.org/r/20071/diff/7/?file=882155#file882155line688>
> >
> >     Adding some comments here would be helpful too.

added comments


- Rakesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20071/#review74761
-----------------------------------------------------------


On March 5, 2015, 6:55 p.m., Rakesh R wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20071/
> -----------------------------------------------------------
> 
> (Updated March 5, 2015, 6:55 p.m.)
> 
> 
> Review request for zookeeper, michim, Raul Gutierrez Segales, and Camille Fournier.
> 
> 
> Bugs: ZOOKEEPER-1907
>     https://issues.apache.org/jira/browse/ZOOKEEPER-1907
> 
> 
> Repository: zookeeper
> 
> 
> Description
> -------
> 
> Improve the thread handling mechanism by detecting if any of the critical thread dies.
> Here the idea is to periodically checking the status of all the critical threads in ZK server using DeathWatcherThread.
> 
> 
> Diffs
> -----
> 
>   ./src/java/main/org/apache/zookeeper/server/ExitCode.java PRE-CREATION 
>   ./src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/ZooKeeperCriticalThread.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/ZooKeeperServerListener.java PRE-CREATION 
>   ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/quorum/FollowerZooKeeperServer.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/quorum/LeaderSessionTracker.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/quorum/LearnerSessionTracker.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/quorum/LearnerZooKeeperServer.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/quorum/LocalSessionTracker.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/quorum/ObserverZooKeeperServer.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyZooKeeperServer.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/quorum/UpgradeableSessionTracker.java 1664445 
>   ./src/java/test/org/apache/zookeeper/server/ZooKeeperThreadTest.java 1664445 
>   ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorConcurrencyTest.java 1664445 
>   ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java 1664445 
>   ./src/java/test/org/apache/zookeeper/test/ClientBase.java 1664445 
>   ./src/java/test/org/apache/zookeeper/test/SessionTrackerCheckTest.java 1664445 
> 
> Diff: https://reviews.apache.org/r/20071/diff/
> 
> 
> Testing
> -------
> 
> yet to be inlcuded
> 
> 
> Thanks,
> 
> Rakesh R
> 
>


Re: Review Request 20071: ZOOKEEPER-1907]-mprove the thread handling by detecting if any of the critical thread dies.

Posted by Rakesh R <ra...@huawei.com>.

> On March 2, 2015, 5:35 p.m., Hongchao Deng wrote:
> > ./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java, line 688
> > <https://reviews.apache.org/r/20071/diff/7/?file=882155#file882155line688>
> >
> >     Adding some comments here would be helpful too.
> 
> Rakesh R wrote:
>     added comments

done


- Rakesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20071/#review74761
-----------------------------------------------------------


On March 5, 2015, 6:55 p.m., Rakesh R wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20071/
> -----------------------------------------------------------
> 
> (Updated March 5, 2015, 6:55 p.m.)
> 
> 
> Review request for zookeeper, michim, Raul Gutierrez Segales, and Camille Fournier.
> 
> 
> Bugs: ZOOKEEPER-1907
>     https://issues.apache.org/jira/browse/ZOOKEEPER-1907
> 
> 
> Repository: zookeeper
> 
> 
> Description
> -------
> 
> Improve the thread handling mechanism by detecting if any of the critical thread dies.
> Here the idea is to periodically checking the status of all the critical threads in ZK server using DeathWatcherThread.
> 
> 
> Diffs
> -----
> 
>   ./src/java/main/org/apache/zookeeper/server/ExitCode.java PRE-CREATION 
>   ./src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/ZooKeeperCriticalThread.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/ZooKeeperServerListener.java PRE-CREATION 
>   ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/quorum/FollowerZooKeeperServer.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/quorum/LeaderSessionTracker.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/quorum/LearnerSessionTracker.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/quorum/LearnerZooKeeperServer.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/quorum/LocalSessionTracker.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/quorum/ObserverZooKeeperServer.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyZooKeeperServer.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/quorum/UpgradeableSessionTracker.java 1664445 
>   ./src/java/test/org/apache/zookeeper/server/ZooKeeperThreadTest.java 1664445 
>   ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorConcurrencyTest.java 1664445 
>   ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java 1664445 
>   ./src/java/test/org/apache/zookeeper/test/ClientBase.java 1664445 
>   ./src/java/test/org/apache/zookeeper/test/SessionTrackerCheckTest.java 1664445 
> 
> Diff: https://reviews.apache.org/r/20071/diff/
> 
> 
> Testing
> -------
> 
> yet to be inlcuded
> 
> 
> Thanks,
> 
> Rakesh R
> 
>


Re: Review Request 20071: ZOOKEEPER-1907]-mprove the thread handling by detecting if any of the critical thread dies.

Posted by Hongchao Deng <hd...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20071/#review74761
-----------------------------------------------------------



./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java
<https://reviews.apache.org/r/20071/#comment121478>

    Adding some comments here would be helpful too.


- Hongchao Deng


On March 2, 2015, 5:26 p.m., Rakesh R wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20071/
> -----------------------------------------------------------
> 
> (Updated March 2, 2015, 5:26 p.m.)
> 
> 
> Review request for zookeeper, michim, Raul Gutierrez Segales, and Camille Fournier.
> 
> 
> Bugs: ZOOKEEPER-1907
>     https://issues.apache.org/jira/browse/ZOOKEEPER-1907
> 
> 
> Repository: zookeeper
> 
> 
> Description
> -------
> 
> Improve the thread handling mechanism by detecting if any of the critical thread dies.
> Here the idea is to periodically checking the status of all the critical threads in ZK server using DeathWatcherThread.
> 
> 
> Diffs
> -----
> 
>   ./src/java/main/org/apache/zookeeper/server/ExitCode.java PRE-CREATION 
>   ./src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 1661461 
>   ./src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java 1661461 
>   ./src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java 1661461 
>   ./src/java/main/org/apache/zookeeper/server/ZooKeeperCriticalThread.java 1661461 
>   ./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 1661461 
>   ./src/java/main/org/apache/zookeeper/server/ZooKeeperServerListener.java PRE-CREATION 
>   ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java 1661461 
>   ./src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java 1661461 
>   ./src/java/main/org/apache/zookeeper/server/quorum/FollowerZooKeeperServer.java 1661461 
>   ./src/java/main/org/apache/zookeeper/server/quorum/LeaderSessionTracker.java 1661461 
>   ./src/java/main/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java 1661461 
>   ./src/java/main/org/apache/zookeeper/server/quorum/LearnerSessionTracker.java 1661461 
>   ./src/java/main/org/apache/zookeeper/server/quorum/LearnerZooKeeperServer.java 1661461 
>   ./src/java/main/org/apache/zookeeper/server/quorum/LocalSessionTracker.java 1661461 
>   ./src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java 1661461 
>   ./src/java/main/org/apache/zookeeper/server/quorum/ObserverZooKeeperServer.java 1661461 
>   ./src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java 1661461 
>   ./src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyZooKeeperServer.java 1661461 
>   ./src/java/main/org/apache/zookeeper/server/quorum/UpgradeableSessionTracker.java 1661461 
>   ./src/java/test/org/apache/zookeeper/server/ZooKeeperThreadTest.java 1661461 
>   ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorConcurrencyTest.java 1661461 
>   ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java 1661461 
>   ./src/java/test/org/apache/zookeeper/test/ClientBase.java 1661461 
>   ./src/java/test/org/apache/zookeeper/test/SessionTrackerCheckTest.java 1661461 
> 
> Diff: https://reviews.apache.org/r/20071/diff/
> 
> 
> Testing
> -------
> 
> yet to be inlcuded
> 
> 
> Thanks,
> 
> Rakesh R
> 
>


Re: Review Request 20071: ZOOKEEPER-1907]-mprove the thread handling by detecting if any of the critical thread dies.

Posted by Rakesh R <ra...@huawei.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20071/
-----------------------------------------------------------

(Updated March 5, 2015, 6:55 p.m.)


Review request for zookeeper, michim, Raul Gutierrez Segales, and Camille Fournier.


Bugs: ZOOKEEPER-1907
    https://issues.apache.org/jira/browse/ZOOKEEPER-1907


Repository: zookeeper


Description
-------

Improve the thread handling mechanism by detecting if any of the critical thread dies.
Here the idea is to periodically checking the status of all the critical threads in ZK server using DeathWatcherThread.


Diffs (updated)
-----

  ./src/java/main/org/apache/zookeeper/server/ExitCode.java PRE-CREATION 
  ./src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 1664445 
  ./src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java 1664445 
  ./src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java 1664445 
  ./src/java/main/org/apache/zookeeper/server/ZooKeeperCriticalThread.java 1664445 
  ./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 1664445 
  ./src/java/main/org/apache/zookeeper/server/ZooKeeperServerListener.java PRE-CREATION 
  ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java 1664445 
  ./src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java 1664445 
  ./src/java/main/org/apache/zookeeper/server/quorum/FollowerZooKeeperServer.java 1664445 
  ./src/java/main/org/apache/zookeeper/server/quorum/LeaderSessionTracker.java 1664445 
  ./src/java/main/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java 1664445 
  ./src/java/main/org/apache/zookeeper/server/quorum/LearnerSessionTracker.java 1664445 
  ./src/java/main/org/apache/zookeeper/server/quorum/LearnerZooKeeperServer.java 1664445 
  ./src/java/main/org/apache/zookeeper/server/quorum/LocalSessionTracker.java 1664445 
  ./src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java 1664445 
  ./src/java/main/org/apache/zookeeper/server/quorum/ObserverZooKeeperServer.java 1664445 
  ./src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java 1664445 
  ./src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyZooKeeperServer.java 1664445 
  ./src/java/main/org/apache/zookeeper/server/quorum/UpgradeableSessionTracker.java 1664445 
  ./src/java/test/org/apache/zookeeper/server/ZooKeeperThreadTest.java 1664445 
  ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorConcurrencyTest.java 1664445 
  ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java 1664445 
  ./src/java/test/org/apache/zookeeper/test/ClientBase.java 1664445 
  ./src/java/test/org/apache/zookeeper/test/SessionTrackerCheckTest.java 1664445 

Diff: https://reviews.apache.org/r/20071/diff/


Testing
-------

yet to be inlcuded


Thanks,

Rakesh R


Re: Review Request 20071: ZOOKEEPER-1907]-mprove the thread handling by detecting if any of the critical thread dies.

Posted by Rakesh R <ra...@huawei.com>.

> On March 2, 2015, 5:30 p.m., Hongchao Deng wrote:
> > ./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java, line 149
> > <https://reviews.apache.org/r/20071/diff/6-7/?file=868720#file868720line149>
> >
> >     not needed

done


> On March 2, 2015, 5:30 p.m., Hongchao Deng wrote:
> > ./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java, line 137
> > <https://reviews.apache.org/r/20071/diff/6-7/?file=868720#file868720line137>
> >
> >     not needed.

done


> On March 2, 2015, 5:30 p.m., Hongchao Deng wrote:
> > ./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java, line 690
> > <https://reviews.apache.org/r/20071/diff/6-7/?file=868720#file868720line690>
> >
> >     state != State.Running.
> 
> Hongchao Deng wrote:
>     Or we can just leave "if (firstProcessor == null) {" unchanged. This is the original behavior.

Modified as state!=State.RUNNING


- Rakesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20071/#review74757
-----------------------------------------------------------


On March 5, 2015, 6:55 p.m., Rakesh R wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20071/
> -----------------------------------------------------------
> 
> (Updated March 5, 2015, 6:55 p.m.)
> 
> 
> Review request for zookeeper, michim, Raul Gutierrez Segales, and Camille Fournier.
> 
> 
> Bugs: ZOOKEEPER-1907
>     https://issues.apache.org/jira/browse/ZOOKEEPER-1907
> 
> 
> Repository: zookeeper
> 
> 
> Description
> -------
> 
> Improve the thread handling mechanism by detecting if any of the critical thread dies.
> Here the idea is to periodically checking the status of all the critical threads in ZK server using DeathWatcherThread.
> 
> 
> Diffs
> -----
> 
>   ./src/java/main/org/apache/zookeeper/server/ExitCode.java PRE-CREATION 
>   ./src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/ZooKeeperCriticalThread.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/ZooKeeperServerListener.java PRE-CREATION 
>   ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/quorum/FollowerZooKeeperServer.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/quorum/LeaderSessionTracker.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/quorum/LearnerSessionTracker.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/quorum/LearnerZooKeeperServer.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/quorum/LocalSessionTracker.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/quorum/ObserverZooKeeperServer.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyZooKeeperServer.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/quorum/UpgradeableSessionTracker.java 1664445 
>   ./src/java/test/org/apache/zookeeper/server/ZooKeeperThreadTest.java 1664445 
>   ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorConcurrencyTest.java 1664445 
>   ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java 1664445 
>   ./src/java/test/org/apache/zookeeper/test/ClientBase.java 1664445 
>   ./src/java/test/org/apache/zookeeper/test/SessionTrackerCheckTest.java 1664445 
> 
> Diff: https://reviews.apache.org/r/20071/diff/
> 
> 
> Testing
> -------
> 
> yet to be inlcuded
> 
> 
> Thanks,
> 
> Rakesh R
> 
>


Re: Review Request 20071: ZOOKEEPER-1907]-mprove the thread handling by detecting if any of the critical thread dies.

Posted by Hongchao Deng <hd...@cloudera.com>.

> On March 2, 2015, 5:30 p.m., Hongchao Deng wrote:
> > ./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java, line 690
> > <https://reviews.apache.org/r/20071/diff/6-7/?file=868720#file868720line690>
> >
> >     state != State.Running.

Or we can just leave "if (firstProcessor == null) {" unchanged. This is the original behavior.


- Hongchao


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20071/#review74757
-----------------------------------------------------------


On March 2, 2015, 5:26 p.m., Rakesh R wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20071/
> -----------------------------------------------------------
> 
> (Updated March 2, 2015, 5:26 p.m.)
> 
> 
> Review request for zookeeper, michim, Raul Gutierrez Segales, and Camille Fournier.
> 
> 
> Bugs: ZOOKEEPER-1907
>     https://issues.apache.org/jira/browse/ZOOKEEPER-1907
> 
> 
> Repository: zookeeper
> 
> 
> Description
> -------
> 
> Improve the thread handling mechanism by detecting if any of the critical thread dies.
> Here the idea is to periodically checking the status of all the critical threads in ZK server using DeathWatcherThread.
> 
> 
> Diffs
> -----
> 
>   ./src/java/main/org/apache/zookeeper/server/ExitCode.java PRE-CREATION 
>   ./src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 1661461 
>   ./src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java 1661461 
>   ./src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java 1661461 
>   ./src/java/main/org/apache/zookeeper/server/ZooKeeperCriticalThread.java 1661461 
>   ./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 1661461 
>   ./src/java/main/org/apache/zookeeper/server/ZooKeeperServerListener.java PRE-CREATION 
>   ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java 1661461 
>   ./src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java 1661461 
>   ./src/java/main/org/apache/zookeeper/server/quorum/FollowerZooKeeperServer.java 1661461 
>   ./src/java/main/org/apache/zookeeper/server/quorum/LeaderSessionTracker.java 1661461 
>   ./src/java/main/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java 1661461 
>   ./src/java/main/org/apache/zookeeper/server/quorum/LearnerSessionTracker.java 1661461 
>   ./src/java/main/org/apache/zookeeper/server/quorum/LearnerZooKeeperServer.java 1661461 
>   ./src/java/main/org/apache/zookeeper/server/quorum/LocalSessionTracker.java 1661461 
>   ./src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java 1661461 
>   ./src/java/main/org/apache/zookeeper/server/quorum/ObserverZooKeeperServer.java 1661461 
>   ./src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java 1661461 
>   ./src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyZooKeeperServer.java 1661461 
>   ./src/java/main/org/apache/zookeeper/server/quorum/UpgradeableSessionTracker.java 1661461 
>   ./src/java/test/org/apache/zookeeper/server/ZooKeeperThreadTest.java 1661461 
>   ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorConcurrencyTest.java 1661461 
>   ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java 1661461 
>   ./src/java/test/org/apache/zookeeper/test/ClientBase.java 1661461 
>   ./src/java/test/org/apache/zookeeper/test/SessionTrackerCheckTest.java 1661461 
> 
> Diff: https://reviews.apache.org/r/20071/diff/
> 
> 
> Testing
> -------
> 
> yet to be inlcuded
> 
> 
> Thanks,
> 
> Rakesh R
> 
>


Re: Review Request 20071: ZOOKEEPER-1907]-mprove the thread handling by detecting if any of the critical thread dies.

Posted by Rakesh R <ra...@huawei.com>.

- Rakesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20071/#review74757
-----------------------------------------------------------


On March 5, 2015, 6:55 p.m., Rakesh R wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20071/
> -----------------------------------------------------------
> 
> (Updated March 5, 2015, 6:55 p.m.)
> 
> 
> Review request for zookeeper, michim, Raul Gutierrez Segales, and Camille Fournier.
> 
> 
> Bugs: ZOOKEEPER-1907
>     https://issues.apache.org/jira/browse/ZOOKEEPER-1907
> 
> 
> Repository: zookeeper
> 
> 
> Description
> -------
> 
> Improve the thread handling mechanism by detecting if any of the critical thread dies.
> Here the idea is to periodically checking the status of all the critical threads in ZK server using DeathWatcherThread.
> 
> 
> Diffs
> -----
> 
>   ./src/java/main/org/apache/zookeeper/server/ExitCode.java PRE-CREATION 
>   ./src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/ZooKeeperCriticalThread.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/ZooKeeperServerListener.java PRE-CREATION 
>   ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/quorum/FollowerZooKeeperServer.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/quorum/LeaderSessionTracker.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/quorum/LearnerSessionTracker.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/quorum/LearnerZooKeeperServer.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/quorum/LocalSessionTracker.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/quorum/ObserverZooKeeperServer.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyZooKeeperServer.java 1664445 
>   ./src/java/main/org/apache/zookeeper/server/quorum/UpgradeableSessionTracker.java 1664445 
>   ./src/java/test/org/apache/zookeeper/server/ZooKeeperThreadTest.java 1664445 
>   ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorConcurrencyTest.java 1664445 
>   ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java 1664445 
>   ./src/java/test/org/apache/zookeeper/test/ClientBase.java 1664445 
>   ./src/java/test/org/apache/zookeeper/test/SessionTrackerCheckTest.java 1664445 
> 
> Diff: https://reviews.apache.org/r/20071/diff/
> 
> 
> Testing
> -------
> 
> yet to be inlcuded
> 
> 
> Thanks,
> 
> Rakesh R
> 
>


Re: Review Request 20071: ZOOKEEPER-1907]-mprove the thread handling by detecting if any of the critical thread dies.

Posted by Hongchao Deng <hd...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20071/#review74757
-----------------------------------------------------------



./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java
<https://reviews.apache.org/r/20071/#comment121464>

    not needed.



./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java
<https://reviews.apache.org/r/20071/#comment121465>

    not needed



./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java
<https://reviews.apache.org/r/20071/#comment121466>

    state != State.Running.


- Hongchao Deng


On March 2, 2015, 5:26 p.m., Rakesh R wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20071/
> -----------------------------------------------------------
> 
> (Updated March 2, 2015, 5:26 p.m.)
> 
> 
> Review request for zookeeper, michim, Raul Gutierrez Segales, and Camille Fournier.
> 
> 
> Bugs: ZOOKEEPER-1907
>     https://issues.apache.org/jira/browse/ZOOKEEPER-1907
> 
> 
> Repository: zookeeper
> 
> 
> Description
> -------
> 
> Improve the thread handling mechanism by detecting if any of the critical thread dies.
> Here the idea is to periodically checking the status of all the critical threads in ZK server using DeathWatcherThread.
> 
> 
> Diffs
> -----
> 
>   ./src/java/main/org/apache/zookeeper/server/ExitCode.java PRE-CREATION 
>   ./src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 1661461 
>   ./src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java 1661461 
>   ./src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java 1661461 
>   ./src/java/main/org/apache/zookeeper/server/ZooKeeperCriticalThread.java 1661461 
>   ./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 1661461 
>   ./src/java/main/org/apache/zookeeper/server/ZooKeeperServerListener.java PRE-CREATION 
>   ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java 1661461 
>   ./src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java 1661461 
>   ./src/java/main/org/apache/zookeeper/server/quorum/FollowerZooKeeperServer.java 1661461 
>   ./src/java/main/org/apache/zookeeper/server/quorum/LeaderSessionTracker.java 1661461 
>   ./src/java/main/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java 1661461 
>   ./src/java/main/org/apache/zookeeper/server/quorum/LearnerSessionTracker.java 1661461 
>   ./src/java/main/org/apache/zookeeper/server/quorum/LearnerZooKeeperServer.java 1661461 
>   ./src/java/main/org/apache/zookeeper/server/quorum/LocalSessionTracker.java 1661461 
>   ./src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java 1661461 
>   ./src/java/main/org/apache/zookeeper/server/quorum/ObserverZooKeeperServer.java 1661461 
>   ./src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java 1661461 
>   ./src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyZooKeeperServer.java 1661461 
>   ./src/java/main/org/apache/zookeeper/server/quorum/UpgradeableSessionTracker.java 1661461 
>   ./src/java/test/org/apache/zookeeper/server/ZooKeeperThreadTest.java 1661461 
>   ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorConcurrencyTest.java 1661461 
>   ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java 1661461 
>   ./src/java/test/org/apache/zookeeper/test/ClientBase.java 1661461 
>   ./src/java/test/org/apache/zookeeper/test/SessionTrackerCheckTest.java 1661461 
> 
> Diff: https://reviews.apache.org/r/20071/diff/
> 
> 
> Testing
> -------
> 
> yet to be inlcuded
> 
> 
> Thanks,
> 
> Rakesh R
> 
>