You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2022/04/22 13:35:00 UTC

[jira] [Commented] (OFBIZ-12603) In place editor wrong enable on display field

    [ https://issues.apache.org/jira/browse/OFBIZ-12603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526428#comment-17526428 ] 

ASF subversion and git services commented on OFBIZ-12603:
---------------------------------------------------------

Commit 44324fc2430c2f62351e6f7ec4ff2fa113188692 in ofbiz-framework's branch refs/heads/release22.01 from Nicolas Malin
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=44324fc243 ]

Fixed: In place editor wrong enable on display field (OFBIZ-12603)

When, on a form, you set a widget-style on a display field, you activate the inline editor without reason.
The issue comes from HtmlFormMacroLibrary.ftl that initialize some value in a span without control if it's necessary.


> In place editor wrong enable on display field
> ---------------------------------------------
>
>                 Key: OFBIZ-12603
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-12603
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework/widget, themes
>    Affects Versions: 18.12.06, 22.01.01, Upcoming Branch
>            Reporter: Nicolas Malin
>            Assignee: Nicolas Malin
>            Priority: Trivial
>
> When, on a form, you set a widget-style on a display field, you activate the inline editor without reason.
> The issue comes from HtmlFormMacroLibrary.ftl that initialize some value in a span 
> {code:java}
>     <#if inPlaceEditorUrl?has_content || class?has_content || alert=="true" || title?has_content>
>       <span data-inplace-editor-url="${inPlaceEditorUrl}" data-inplace-editor-params="${inPlaceEditorParams}" <#if idName?has_content>id="cc_${idName}"</#if> <#if title?has_content>title="${title}"</#if> <@renderClass class alert />><#t/>
>     </#if>{code}
> With the previous code, if you have a class value, the span received in place editor elements without reason. 



--
This message was sent by Atlassian Jira
(v8.20.7#820007)