[GitHub] [geode] jinmeiliao opened pull request #3407: GEODE-6505: move RegionShortcut and ExpirationAction back to core

["jinmeiliao (GitHub)" <gi...@apache.org>]

* use a different enum in geode-management module for recommended types
* make ExpirationAction a true enum and move it back to core
* use string for expiration action in geode-management module and add validation

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/3407 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jdeppe-pivotal commented on pull request #3407: GEODE-6505: move RegionShortcut and ExpirationAction back to core

["jdeppe-pivotal (GitHub)" <gi...@apache.org>]

I think it would be nice to uppercase the value here so that users can use either case.

[ Full content available at: https://github.com/apache/geode/pull/3407 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jinmeiliao closed pull request #3407: GEODE-6505: move RegionShortcut and ExpirationAction back to core

["jinmeiliao (GitHub)" <gi...@apache.org>]

[ pull request closed by jinmeiliao ]

[ Full content available at: https://github.com/apache/geode/pull/3407 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jdeppe-pivotal commented on pull request #3407: GEODE-6505: move RegionShortcut and ExpirationAction back to core

["jdeppe-pivotal (GitHub)" <gi...@apache.org>]

This is probably a typo.

[ Full content available at: https://github.com/apache/geode/pull/3407 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jinmeiliao commented on issue #3407: GEODE-6505: move RegionShortcut and ExpirationAction back to core

["jinmeiliao (GitHub)" <gi...@apache.org>]

@Petahhh for your review

[ Full content available at: https://github.com/apache/geode/pull/3407 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org