[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request #2641: [GOBBLIN-777] Remove container request after container allocation

[GitBox <gi...@apache.org>]

sv2000 commented on a change in pull request #2641: [GOBBLIN-777] Remove container request after container allocation
URL: https://github.com/apache/incubator-gobblin/pull/2641#discussion_r286111891
 
 

 ##########
 File path: gobblin-yarn/src/test/java/org/apache/gobblin/yarn/YarnServiceTest.java
 ##########
 @@ -197,8 +201,12 @@ public void tearDown() throws IOException, TimeoutException, YarnException {
   public void testScaleUp() {
     this.yarnService.requestTargetNumberOfContainers(10, Collections.EMPTY_SET);
 
+    Assert.assertFalse(this.yarnService.getMatchingRequestsList(64, 1).isEmpty());
     Assert.assertEquals(this.yarnService.getNumRequestedContainers(), 10);
     Assert.assertTrue(this.yarnService.waitForContainerCount(10, 60000));
+
+    // container request list that had entries earlier should now be empty
+    Assert.assertEquals(this.yarnService.getMatchingRequestsList(64, 1).size(), 0);
 
 Review comment:
   Assert.assertTrue(this.yarnService.getMatchingRequestsList(64, 1).isEmpty())? to be consistent with line 204?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services