You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "okumin (via GitHub)" <gi...@apache.org> on 2023/04/02 05:32:08 UTC

[GitHub] [ozone] okumin opened a new pull request, #4515: HDDS-8354: Avoid WARNING about ObjectEndpoint#get

okumin opened a new pull request, #4515:
URL: https://github.com/apache/ozone/pull/4515

   ## What changes were proposed in this pull request?
   
   Make `ObjectEndpoint#get` not accept an HTTP request body so that we no longer see the following WARNING.
   
   ```
   ozone-s3g-6bd9d99555-lgmsl: WARNING: The following warnings have been detected: WARNING: A HTTP GET method, public javax.ws.rs.core.Response org.apache.hadoop.ozone.s3.endpoint.ObjectEndpoint.get(java.lang.String,java.lang.String,java.lang.String,int,java.lang.String,java.io.InputStream) throws java.io.IOException,org.apache.hadoop.ozone.s3.exception.OS3Exception, should not consume any entity. 
   ```
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-8354
   
   ## How was this patch tested?
   
   I verified we never observe the warning the master branch with this patch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] okumin commented on pull request #4515: HDDS-8354. Avoid WARNING about ObjectEndpoint#get

Posted by "okumin (via GitHub)" <gi...@apache.org>.
okumin commented on PR #4515:
URL: https://github.com/apache/ozone/pull/4515#issuecomment-1495325127

   Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] kerneltime commented on pull request #4515: HDDS-8354. Avoid WARNING about ObjectEndpoint#get

Posted by "kerneltime (via GitHub)" <gi...@apache.org>.
kerneltime commented on PR #4515:
URL: https://github.com/apache/ozone/pull/4515#issuecomment-1494738078

   This seems to be the only place we do this. Thanks for the fix!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] kerneltime commented on pull request #4515: HDDS-8354. Avoid WARNING about ObjectEndpoint#get

Posted by "kerneltime (via GitHub)" <gi...@apache.org>.
kerneltime commented on PR #4515:
URL: https://github.com/apache/ozone/pull/4515#issuecomment-1494626343

   cc @tanvipenumudy @SaketaChalamchala @xBis7 can you please take a look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] okumin commented on pull request #4515: HDDS-8354. Avoid WARNING about ObjectEndpoint#get

Posted by "okumin (via GitHub)" <gi...@apache.org>.
okumin commented on PR #4515:
URL: https://github.com/apache/ozone/pull/4515#issuecomment-1493379098

   @adoroszlai Thanks and sorry I missed https://github.com/apache/ozone/blob/master/CONTRIBUTING.md.
   I enabled the CI action, fixing the checkstyle error.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] adoroszlai commented on pull request #4515: HDDS-8354. Avoid WARNING about ObjectEndpoint#get

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #4515:
URL: https://github.com/apache/ozone/pull/4515#issuecomment-1493400403

   @duongkame @kerneltime @xichen01 would you like to take a look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] adoroszlai commented on a diff in pull request #4515: HDDS-8354: Avoid WARNING about ObjectEndpoint#get

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #4515:
URL: https://github.com/apache/ozone/pull/4515#discussion_r1155266984


##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/ObjectEndpoint.java:
##########
@@ -300,8 +300,7 @@ public Response get(
       @PathParam("path") String keyPath,
       @QueryParam("uploadId") String uploadId,
       @QueryParam("max-parts") @DefaultValue("1000") int maxParts,
-      @QueryParam("part-number-marker") String partNumberMarker,
-      InputStream body) throws IOException, OS3Exception {
+      @QueryParam("part-number-marker") String partNumberMarker) throws IOException, OS3Exception {

Review Comment:
   This line is too long for checkstyle:
   
   ```
   hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/ObjectEndpoint.java
    303: Line is longer than 80 characters (found 99).
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] adoroszlai merged pull request #4515: HDDS-8354. Avoid WARNING about ObjectEndpoint#get

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #4515:
URL: https://github.com/apache/ozone/pull/4515


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org