You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jiangyinzuo (via GitHub)" <gi...@apache.org> on 2023/03/25 15:58:34 UTC

[GitHub] [arrow-datafusion] jiangyinzuo commented on a diff in pull request #5741: Modify tests for TPCH explain plans to avoid regressions

jiangyinzuo commented on code in PR #5741:
URL: https://github.com/apache/arrow-datafusion/pull/5741#discussion_r1148394736


##########
benchmarks/src/bin/tpch.rs:
##########
@@ -525,13 +525,19 @@ mod tests {
         let mut actual = String::new();
         let sql = get_query_sql(query)?;
         for sql in &sql {
-            let df = ctx.sql(sql.as_str()).await?;
-            let plan = df.into_optimized_plan()?;
-            if !actual.is_empty() {
-                actual += "\n";
+            if sql.starts_with("select") {

Review Comment:
   handle special query 15 which contains `create view` sql statement



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org