You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/22 22:56:45 UTC
[GitHub] [superset] junlincc opened a new issue #12700: [dashboard]native-filter inconsistent select dropdown
junlincc opened a new issue #12700:
URL: https://github.com/apache/superset/issues/12700
Looks like the incompatible filters have a different select dropdown. Let's make sure all the select field has 1)caret 2)magnifier icon for consistency
https://user-images.githubusercontent.com/67837651/105557616-84b79780-5cc1-11eb-8e42-b6671fa89035.mov
@agatapst
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #12700: [dashboard]native-filter cosmetic issues
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12700:
URL: https://github.com/apache/superset/issues/12700#issuecomment-766235868
<img width="1348" alt="Screen Shot 2021-01-23 at 3 55 18 PM" src="https://user-images.githubusercontent.com/67837651/105617518-7a65ce00-5d93-11eb-80ea-762afbc79816.png">
line break when select value is truncated. ideally the cursor should be in the same line 🙏
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on issue #12700: [dashboard]native-filter cosmetic issues
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #12700:
URL: https://github.com/apache/superset/issues/12700#issuecomment-766235868
<img width="1348" alt="Screen Shot 2021-01-23 at 3 55 18 PM" src="https://user-images.githubusercontent.com/67837651/105617558-ae40f380-5d93-11eb-8638-ca6c7509798c.png">
line break when select value is truncated. ideally the cursor should be in the same line 🙏
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc closed issue #12700: [dashboard]native-filter cosmetic issues
Posted by GitBox <gi...@apache.org>.
junlincc closed issue #12700:
URL: https://github.com/apache/superset/issues/12700
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on issue #12700: [dashboard]native-filter inconsistent select box
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #12700:
URL: https://github.com/apache/superset/issues/12700#issuecomment-765758334
<img width="1025" alt="Screen Shot 2021-01-22 at 3 39 54 PM" src="https://user-images.githubusercontent.com/67837651/105560288-34900380-5cc8-11eb-8f9f-4bcc324a630b.png">
let's stack `FILTER NAME` under `FIELD`, make it only one column without increasing the height of modal by narrowing and standardizing the spacing between fields.
Rename "Datasource" to "Dataset"
all these changes can go into one PR. @agatapst thank you for taking care of native filter!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #12700: [dashboard]native-filter inconsistent select box
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12700:
URL: https://github.com/apache/superset/issues/12700#issuecomment-765758334
<img width="1025" alt="Screen Shot 2021-01-22 at 3 39 54 PM" src="https://user-images.githubusercontent.com/67837651/105560288-34900380-5cc8-11eb-8f9f-4bcc324a630b.png">
let's stack FILTER NAME under FIELD, make it only one column without increasing the height of modal by narrowing and standardizing the spacing between fields.
Rename "Datasource" to "Dataset"
all these changes can go into one PR. @agatapst thank you for taking care of native filter!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #12700: [dashboard]native-filter inconsistent select box
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12700:
URL: https://github.com/apache/superset/issues/12700#issuecomment-765749817
<img width="643" alt="Screen Shot 2021-01-22 at 3 37 41 PM" src="https://user-images.githubusercontent.com/67837651/105560117-c9dec800-5cc7-11eb-94fc-8248050fa006.png">
also the right side of dropdown in FIELD select is missing.
🙏 @agatapst
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org